-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension for schema.org/Skiresort #1259
Conversation
…p engine deployment
… still open for discussion
@RichardWallis @danbri any thoughts on merging my pull request after the discussion on the mailing list last month? thanks! |
Hi, |
+1 to add this to pending for now. @eliaskaerle Can you change the definitions for elevationEnd and elevationStart to be: Elevation at the end or TOP of the lift. |
A few quick comments:
|
'difficulty' should be renamed 'skiSlopeDifficulty' because its really the slope number that has a difficulty rating. |
@thadguidry, @vholland, thanks, I agree and will implement the changes as suggest. @vholland: the slope number is the primary key or UID for slopes inside a ski resort. (see this slope map for example: http://www.skiresort.de/uploads/tx_mgskiresort/obergurgl.jpg ) But I agree that the description is poor, I'll update that. |
Any further suggestions, comments, issues or potential changes? |
Hi @RichardWallis and @danbri, |
The Does it make more sense to have a general |
Does it make more sense to have a general DifficultyRating and then describe known schemes such as ski slopes?
+1
… On 3 Mar 2017, at 18:50, chaals ***@***.***> wrote:
nd then describe known schemes such as ski slopes?
—
|
agree re difficulty - we should address it alongside #647 and related |
Ok. Should I take 'skiSlopeDifficulty' out temporarily, that the extension can make it into 3.2, or do we set up a 'DifficultyRating' right away? |
Dear @RichardWallis , can you tell me why you closed that pull request? Do I have to file a new one? I would still like to have this terms in schema. |
@eliaskaerle Sorry, the automatic close was an unexpected consequence of removing a stale branch (schemaorg:sdo-makemake) that was way behind the current master branch. It should be recreatable by bringing eliaskaerle:sdo-makemake in line wih schemaorg:master and creating a new PR. |
@RichardWallis I see, thanks for the answer. I'll do that! |
schema.org/SkiResort - Extension
abstract
This pull request suggests an extension to the class schema.org/SkiResort to add functionality for annotating SkiLifts and SkiSlopes. This topic was discussed on the public schema.org mailing list and the suggestions made by members of the list to improve this extension were incorporated (see public-schemaorg, starting on Wed, 20 July 2016).
why
We were annotating the website of a tourism region and came across the need to annotate ski resorts. Unfortunately there was no possibility in schema.org to annotate ski lifts and ski slopes. So we made the extension of schema.org/SkiResort to annotate ski lifts and ski slopes.
how
list of new classes:
list of new properties:
see figure:
online documentation