Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension for schema.org/Skiresort #1259

Closed
wants to merge 17 commits into from

Conversation

eliaskaerle
Copy link

@eliaskaerle eliaskaerle commented Jul 25, 2016

schema.org/SkiResort - Extension

abstract

This pull request suggests an extension to the class schema.org/SkiResort to add functionality for annotating SkiLifts and SkiSlopes. This topic was discussed on the public schema.org mailing list and the suggestions made by members of the list to improve this extension were incorporated (see public-schemaorg, starting on Wed, 20 July 2016).

why

We were annotating the website of a tourism region and came across the need to annotate ski resorts. Unfortunately there was no possibility in schema.org to annotate ski lifts and ski slopes. So we made the extension of schema.org/SkiResort to annotate ski lifts and ski slopes.

how

  • schema.org/SkiResort was extended by two properties
  • two new classes were introduced with eight new properties in total

list of new classes:

list of new properties:

see figure:

Diagram of the Extension

online documentation

@eliaskaerle
Copy link
Author

@eliaskaerle eliaskaerle commented Aug 19, 2016

@RichardWallis @danbri any thoughts on merging my pull request after the discussion on the mailing list last month? thanks!

@eliaskaerle
Copy link
Author

@eliaskaerle eliaskaerle commented Sep 13, 2016

Hi,
I would like to know if there is anything I can do to proceed with my ski resort proposal. We already had a discussion on the mailing list which came to no real conclusion. Any thoughts?
Thanks!

@thadguidry
Copy link
Contributor

@thadguidry thadguidry commented Sep 13, 2016

+1 to add this to pending for now.

@eliaskaerle Can you change the definitions for elevationEnd and elevationStart to be:

Elevation at the end or TOP of the lift.
Elevation at the start or BOTTOM of the lift.

@vholland
Copy link
Contributor

@vholland vholland commented Sep 13, 2016

A few quick comments:

  • Can we rename 'liftType' to something less generic like 'skiLiftType'?
  • Can we reuse http://schema.org/distance rather than introduce 'length'?
  • Can we rename 'difficulty' to something less generic?
  • What is the slope number? The description and examples don't really explain what is being conveyed.

@thadguidry
Copy link
Contributor

@thadguidry thadguidry commented Sep 13, 2016

'difficulty' should be renamed 'skiSlopeDifficulty' because its really the slope number that has a difficulty rating.

@eliaskaerle
Copy link
Author

@eliaskaerle eliaskaerle commented Sep 14, 2016

@thadguidry, @vholland, thanks, I agree and will implement the changes as suggest.

@vholland: the slope number is the primary key or UID for slopes inside a ski resort. (see this slope map for example: http://www.skiresort.de/uploads/tx_mgskiresort/obergurgl.jpg ) But I agree that the description is poor, I'll update that.

@eliaskaerle
Copy link
Author

@eliaskaerle eliaskaerle commented Sep 20, 2016

Any further suggestions, comments, issues or potential changes?

@eliaskaerle
Copy link
Author

@eliaskaerle eliaskaerle commented Oct 5, 2016

Hi @RichardWallis and @danbri,
is there anything I can do to advance with this pull request or is it finally ready for being merged?
Thanks!

@chaals
Copy link
Contributor

@chaals chaals commented Mar 3, 2017

The skiSlopeDifficulty is related to difficulty for things like instructions - cooking recipes, explanations about how to replace a carburettor, etc.

Does it make more sense to have a general DifficultyRating and then describe known schemes such as ski slopes?

@Dataliberate
Copy link
Contributor

@Dataliberate Dataliberate commented Mar 3, 2017

@danbri
Copy link
Contributor

@danbri danbri commented Mar 3, 2017

agree re difficulty - we should address it alongside

#647 and related

@eliaskaerle
Copy link
Author

@eliaskaerle eliaskaerle commented Mar 3, 2017

Ok. Should I take 'skiSlopeDifficulty' out temporarily, that the extension can make it into 3.2, or do we set up a 'DifficultyRating' right away?

@eliaskaerle
Copy link
Author

@eliaskaerle eliaskaerle commented Feb 17, 2019

Dear @RichardWallis , can you tell me why you closed that pull request? Do I have to file a new one? I would still like to have this terms in schema.
Thanks, best, Elias

@RichardWallis
Copy link
Contributor

@RichardWallis RichardWallis commented Feb 19, 2019

@eliaskaerle Sorry, the automatic close was an unexpected consequence of removing a stale branch (schemaorg:sdo-makemake) that was way behind the current master branch.

It should be recreatable by bringing eliaskaerle:sdo-makemake in line wih schemaorg:master and creating a new PR.

@eliaskaerle
Copy link
Author

@eliaskaerle eliaskaerle commented Feb 19, 2019

@RichardWallis I see, thanks for the answer. I'll do that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants