New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1457 adding schedules #1693

Merged
merged 3 commits into from Jul 14, 2017

Conversation

Projects
None yet
4 participants
@ldodds
Contributor

ldodds commented Jul 12, 2017

Specifies the new terms proposed in #1457.

New Classes:

  • Schedule

New Properties:

  • repeatFrequency
  • repeatCount
  • byDay
  • byMonth
  • byMonthDay
  • exceptDate
  • eventSchedule

Changes from latest proposal in #1457:

  • count has been renamed as occurencyCount to match similar properties elsewhere in Schema.org
  • frequency has been renamed as repeatFrequency to clarify its role, also avoid clashes with term in life-sciences.
  • frequency can be text, but recommended to refer to a Duration
  • Removed interval as this is now covered by frequency

Added some examples of different schedules

@ldodds ldodds referenced this pull request Jul 12, 2017

Closed

Adding Schedules #1457

@ldodds

This comment has been minimized.

Show comment
Hide comment
@ldodds

ldodds Jul 14, 2017

Contributor

@danbri one question: I also need to indicate that a schedule can have a startDate, endDate and duration am I safe to just declare the wider domains for those properties here? Couldn't see an example of this in other changes.

Also, what's the process for getting this merged?

Contributor

ldodds commented Jul 14, 2017

@danbri one question: I also need to indicate that a schedule can have a startDate, endDate and duration am I safe to just declare the wider domains for those properties here? Couldn't see an example of this in other changes.

Also, what's the process for getting this merged?

@nickevansuk

This comment has been minimized.

Show comment
Hide comment
@nickevansuk

nickevansuk Jul 14, 2017

Supportive of this, especially if we can get duration in there.

nickevansuk commented Jul 14, 2017

Supportive of this, especially if we can get duration in there.

@chaals

This comment has been minimized.

Show comment
Hide comment
@chaals

chaals Jul 14, 2017

Contributor

Bikeshed: can we have repeatCount instead of occurencyCount?

It uses more common words, matches the repeatFrequency, and is easier not to spell wrong...

Contributor

chaals commented Jul 14, 2017

Bikeshed: can we have repeatCount instead of occurencyCount?

It uses more common words, matches the repeatFrequency, and is easier not to spell wrong...

@ldodds

This comment has been minimized.

Show comment
Hide comment
@ldodds

ldodds Jul 14, 2017

Contributor

@chaals makes sense to me. I've renamed as suggested

Contributor

ldodds commented Jul 14, 2017

@chaals makes sense to me. I've renamed as suggested

@danbri

This comment has been minimized.

Show comment
Hide comment
@danbri

danbri Jul 14, 2017

Contributor

I suggest I merge this in asap (to pending) to help others review it more carefully. Is anything massively in flux or shall I do that now? we can continue to refine after merging

Contributor

danbri commented Jul 14, 2017

I suggest I merge this in asap (to pending) to help others review it more carefully. Is anything massively in flux or shall I do that now? we can continue to refine after merging

@nickevansuk

This comment has been minimized.

Show comment
Hide comment
@nickevansuk

nickevansuk Jul 14, 2017

@danbri in case @ldodds isn't about, we chatting about this earlier and it's in a good place to merge as-is, as you say to help others review.

nickevansuk commented Jul 14, 2017

@danbri in case @ldodds isn't about, we chatting about this earlier and it's in a good place to merge as-is, as you say to help others review.

@danbri danbri merged commit 7176ea8 into schemaorg:master Jul 14, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@danbri

This comment has been minimized.

Show comment
Hide comment
@danbri

danbri Jul 14, 2017

Contributor

Done. Will stage on webschemas site when I get to https://github.com/t2trg/2017-07-wishi

/cc #1272 re device schedules

Contributor

danbri commented Jul 14, 2017

Done. Will stage on webschemas site when I get to https://github.com/t2trg/2017-07-wishi

/cc #1272 re device schedules

@nickevansuk

This comment has been minimized.

Show comment
Hide comment
@nickevansuk

nickevansuk Jul 14, 2017

Great! Would you also be able to look at @ldodds' question above re: startDate, endDate and duration?

nickevansuk commented Jul 14, 2017

Great! Would you also be able to look at @ldodds' question above re: startDate, endDate and duration?

@nickevansuk

This comment has been minimized.

Show comment
Hide comment
@nickevansuk

nickevansuk Jul 19, 2017

Hey @danbri - sorry if this should be obvious but where can we find this to point people to for feedback?

http://pending.schema.org/Schedule Returns a 404...

nickevansuk commented Jul 19, 2017

Hey @danbri - sorry if this should be obvious but where can we find this to point people to for feedback?

http://pending.schema.org/Schedule Returns a 404...

@ldodds

This comment has been minimized.

Show comment
Hide comment
@ldodds

ldodds Aug 8, 2017

Contributor

@danbri should these terms have appeared at pending.schema.org yet? Getting 404s still. Does a release need to happen?

Contributor

ldodds commented Aug 8, 2017

@danbri should these terms have appeared at pending.schema.org yet? Getting 404s still. Does a release need to happen?

@danbri

This comment has been minimized.

Show comment
Hide comment
@danbri

danbri Aug 8, 2017

Contributor

Normally they'd be on webschemas.org now, and yes will show up on *schema.org with the upcoming release.

Contributor

danbri commented Aug 8, 2017

Normally they'd be on webschemas.org now, and yes will show up on *schema.org with the upcoming release.

@ldodds

This comment has been minimized.

Show comment
Hide comment
@ldodds

ldodds Aug 9, 2017

Contributor

@danbri so they'll appear on http://webschemas.org/Schedule and http://pending.schema.org/Schedule after the next release? When will that be?

I want to update our JSON-LD context to refer to the pending terms.

Contributor

ldodds commented Aug 9, 2017

@danbri so they'll appear on http://webschemas.org/Schedule and http://pending.schema.org/Schedule after the next release? When will that be?

I want to update our JSON-LD context to refer to the pending terms.

@ldodds ldodds referenced this pull request Apr 19, 2018

Open

urlTemplate #14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment