Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced DefinedTerm (prev: TermDefinition) as a super type of CategoryCode #1776

Merged
merged 5 commits into from Apr 18, 2018

Conversation

@RichardWallis
Copy link
Contributor

@RichardWallis RichardWallis commented Oct 22, 2017

Changed CategoryCodes to TermDefinitions Issue #1775

Updated pending definitions and associated examples.

Plus dependant terms in other areas (MedicalCode & legislationType)

@l00mi
Copy link

@l00mi l00mi commented Nov 13, 2017

I am not well educated about the schema.org process. What is necessary that this PR gets accepted?

@RichardWallis
Copy link
Contributor Author

@RichardWallis RichardWallis commented Nov 13, 2017

Hi @l00mi,
Process is that between releases support, or otherwise, for the proposed change is voiced in the comments stream. Ahead of the next release (3.4 is next - date yet to be fixed) PRs are added to the list of potential additions - an aggregating issue is usually created to handle this by @danbri.

Then subject to any further comments, the list of changes for the release is commented on and agreed by the members of the steering committee. See also http://schema.org/docs/howwework.html

~Richard.

@l00mi
Copy link

@l00mi l00mi commented Nov 13, 2017

Splendid, thank you for the thorough explanation @RichardWallis!

@RichardWallis RichardWallis changed the title Changed CategoryCodes to TermDefinitions Changed CategoryCode to be subtype of TermDefinition Dec 8, 2017
@RichardWallis RichardWallis changed the title Changed CategoryCode to be subtype of TermDefinition Introduced TermDefinition as a super type of CategoryCode Jan 16, 2018
@danbri
Copy link
Contributor

@danbri danbri commented Apr 18, 2018

I believe this also attempts to address #251

I suggest exit criteria for moving it out of the pending area include 1.) examination of how / whether it applies to all existing schema.org properties that kinda-sorta take controlled code lists, but which currently say something like "expects URL or Text" 2.) some thought and explanation for how this relates to the (pretty widely adopted in its area) W3C SKOS work, particularly from the perspective of parties publishing controlled code lists, taxonomies and and other such enumerations.

@danbri danbri merged commit 7c1d12d into master Apr 18, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@l00mi
Copy link

@l00mi l00mi commented Apr 18, 2018

@RichardWallis if you need help with one of these tasks please ping me.

Personally I see that SKOS will be the full fledged version of a TermDefinition.

Short possible propositions regarding SKOS:

  1. Where a TermDefinition will be valid, a SKOS Concept is also valid.
  2. There is a Property on the TermDefinition which is pointing to the according SKOS Concept.
  3. We define that a TermDefinition Instance shall have a SKOS Concept class.
@RichardWallis
Copy link
Contributor Author

@RichardWallis RichardWallis commented Apr 18, 2018

If/when this proposal moves out of pending, as @danbri commented, we need to document how TermDefinition etc. relate to other areas (especially SKOS).

Such documentation should be targeted at a few groups:

  • Those that have SKOS defined data and want to add Schema to it
  • Those that want to build/markup new control code lists and understand, or have never heard of, SKOS

As @danbri also comments we need to review default, and or specific, use of TermDefinition as an expected type for schema properties.

Let's see how things map out initially in pending first.

@danbri danbri changed the title Introduced TermDefinition as a super type of CategoryCode Introduced DefinedTerm (prev: TermDefinition) as a super type of CategoryCode Jun 14, 2018
@RichardWallis RichardWallis deleted the definedterm branch Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants