Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove additional itemprop/property attribute on 'Book' example #185

Closed
wants to merge 1 commit into from
Closed

Conversation

unor
Copy link
Contributor

@unor unor commented Nov 23, 2014

A Microdata/RDFa example had two itemprop/property elements on the same element, one of which contained an invalid property value (Fiction).

I guess it was intended to use content="Fiction" instead, but note that Microdata doesn’t allow this on span (see #184) and the JSON-LD example uses "fictional" instead of "Fiction", too.

An example had two itemprop/property elements on the same element, one of which contained no valid property.
@unor unor changed the title 'Book' example contained two itemprop/property attributes on same element Remove additional itemprop/property attribute on 'Book' example Nov 23, 2014
@danbri danbri added guidelines docs examples Work on our supporting materials rather than on schema definitions status:needs review type:cleanup + clarity Addresses wording fixes, ambiguities, confusion, bad examples etc type:bug A mistake or malfunction whose remedy should be straightforward technical work labels Jan 22, 2015
@danbri danbri modified the milestones: 2015 Q1, sdo-stantz release Jan 22, 2015
@danbri danbri self-assigned this Jan 22, 2015
@danbri danbri mentioned this pull request Jan 22, 2015
@danbri
Copy link
Contributor

danbri commented Jan 22, 2015

Thanks! Merged in via #272 (I pulled it into sdo-stantz, our upcoming release, rather than master branch).

@danbri danbri closed this Jan 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
guidelines docs examples Work on our supporting materials rather than on schema definitions type:bug A mistake or malfunction whose remedy should be straightforward technical work type:cleanup + clarity Addresses wording fixes, ambiguities, confusion, bad examples etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants