Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sdo-howto-examples.txt #1902

Merged
merged 2 commits into from
May 1, 2018
Merged

Update sdo-howto-examples.txt #1902

merged 2 commits into from
May 1, 2018

Conversation

RichardWallis
Copy link
Contributor

Fixed issues on the new HowTo examples. Issue (#1899)

@dbiollo thanks for your input on this - I identified a mismatch between the term definitions I was working from and those already committed to webschemas.org. It has resulted in much simpler nesting of types!

Fixed issues on the new HowTo examples.   Issue (#1899)

@dbiollo thanks for your input on this - I identified a mismatch between the term definitions I was working from and those already committed to webschemas.org.  It has resulted in much simpler nesting of types!
<div itemprop="step" itemscope itemtype="http://schema.org/HowToSection">
<div itemprop="name">Preparation</div>
<meta itemprop="position" content="1"/>
<div itemprop="itemListElement" itemscope itemtype="http://schema.org/HowToDirection">
Copy link
Contributor

@dbiollo dbiollo Apr 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there should be a HowToStep wrapping this HowToDirection + HowToTip.
So the structure would be:

  • HowTo
    • HowToSection
      • HowToStep (aka "step 1")
        • HowToDirection
        • HowToTip
      • HowToStep (aka "step 2")
        • HowToDirection
          etc

Maybe a bit verbose, but the Direction + Tip I believe were intended to be parts of an individual Step.

}
],
"supply": {
"@type": "HowToSupply",
"name": "Wheel wedges"
"name": "Flares",
"image": "falares.jpg"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issue: typo - flares.jpg

"name": "Preparation",
"position": "1",
"itemListElement": [
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to comment above, this would be a list of 2 HowToStep's.
HowToDirection & HowToTip would be itemListElement nested in the HowToStep

Fixed a typo
Nested HowToDirection and HowToTip pairs into individual HowToSteps
@RichardWallis
Copy link
Contributor Author

@dbiollo I missed the significance of the HowToStep type in the updated version for nesting pairs of HowToDirection & HowToTip.

Also fixed typo.

Thanks again for your input on this - I think we are getting there!

@danbri
Copy link
Contributor

danbri commented May 1, 2018

Ok it looks like @RichardWallis and @dbiollo have worked this through, I will merge and publish to the staging site but do please take another sanity-check look once I've done that, this markup is really easy to get wrong.

@danbri danbri merged commit 9949fb2 into master May 1, 2018
@danbri
Copy link
Contributor

danbri commented May 2, 2018

PTAL, http://webschemas.org/HowToStep

@RichardWallis RichardWallis deleted the RichardWallis-patch-1 branch February 15, 2019 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants