New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sdo-howto-examples.txt #1902

Merged
merged 2 commits into from May 1, 2018

Conversation

Projects
None yet
3 participants
@RichardWallis
Contributor

RichardWallis commented Apr 27, 2018

Fixed issues on the new HowTo examples. Issue (#1899)

@dbiollo thanks for your input on this - I identified a mismatch between the term definitions I was working from and those already committed to webschemas.org. It has resulted in much simpler nesting of types!

Update sdo-howto-examples.txt
Fixed issues on the new HowTo examples.   Issue (#1899)

@dbiollo thanks for your input on this - I identified a mismatch between the term definitions I was working from and those already committed to webschemas.org.  It has resulted in much simpler nesting of types!
<div itemprop="step" itemscope itemtype="http://schema.org/HowToSection">
<div itemprop="name">Preparation</div>
<meta itemprop="position" content="1"/>
<div itemprop="itemListElement" itemscope itemtype="http://schema.org/HowToDirection">

This comment has been minimized.

@dbiollo

dbiollo Apr 27, 2018

Contributor

I believe there should be a HowToStep wrapping this HowToDirection + HowToTip.
So the structure would be:

  • HowTo
    • HowToSection
      • HowToStep (aka "step 1")
        • HowToDirection
        • HowToTip
      • HowToStep (aka "step 2")
        • HowToDirection
          etc

Maybe a bit verbose, but the Direction + Tip I believe were intended to be parts of an individual Step.

}
],
"supply": {
"@type": "HowToSupply",
"name": "Wheel wedges"
"name": "Flares",
"image": "falares.jpg"

This comment has been minimized.

@dbiollo

dbiollo Apr 27, 2018

Contributor

Minor issue: typo - flares.jpg

"name": "Preparation",
"position": "1",
"itemListElement": [
{

This comment has been minimized.

@dbiollo

dbiollo Apr 27, 2018

Contributor

Similar to comment above, this would be a list of 2 HowToStep's.
HowToDirection & HowToTip would be itemListElement nested in the HowToStep

Further updates to sdo-howto-examples.txt
Fixed a typo
Nested HowToDirection and HowToTip pairs into individual HowToSteps
@RichardWallis

This comment has been minimized.

Contributor

RichardWallis commented Apr 27, 2018

@dbiollo I missed the significance of the HowToStep type in the updated version for nesting pairs of HowToDirection & HowToTip.

Also fixed typo.

Thanks again for your input on this - I think we are getting there!

@danbri

This comment has been minimized.

Contributor

danbri commented May 1, 2018

Ok it looks like @RichardWallis and @dbiollo have worked this through, I will merge and publish to the staging site but do please take another sanity-check look once I've done that, this markup is really easy to get wrong.

@danbri danbri merged commit 9949fb2 into master May 1, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@danbri

This comment has been minimized.

Contributor

danbri commented May 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment