Example fixes #199

Closed
wants to merge 12 commits into
from

Projects

None yet

4 participants

@gkellogg
Contributor

I went through and fixed many examples, one of which was actually causing my RDFa processor to hang! Everything else should be non-controversial, but there are some issues that indicate properties might be misnamed.

There are many more markup issues, and it would be great if new examples passed some form of validation before being incorporated. These were identified using a command-line tool in the linter.

@gkellogg
Contributor

@danbri if there's a better place for this PR to go, let me know. I may continue updating the PR with new example fixes until then.

@danbri danbri self-assigned this Jan 20, 2015
@danbri danbri added this to the sdo-stantz release milestone Jan 20, 2015
@danbri
Contributor
danbri commented Jan 22, 2015

Just to say a huge thanks for doing these. There's a bit of administrivia to do first before integrating but ... thanks - much appreciated :)

@danbri
danbri commented on b6679a5 Jan 22, 2015

I think that first one should be %20 not just % ...?

line 735: Monopoly%Game">

suggest: Monopoly%20Game">

@danbri danbri referenced this pull request Jan 22, 2015
Merged

Example fixes #260

@danbri
Contributor
danbri commented Jan 22, 2015

Ok I've merged in #260 ... can we close this version?

I made the %20 tweak afterwards.

Suggestions for better workflow welcomed - would you prefer I ask the original pull request to be reconfigured to another branch? in this case I wanted it against sdo-stantz rather than master branch, and it seemed easier just to make another quick pull request. I couldn't see a way to change this one myself.

@scor
Contributor
scor commented Jan 22, 2015

You cannot change the target branch once the pull request is created, you have to create a new one, as inconvenient as it is...

What if you set the default branch and adjusted it accordingly after each release? https://help.github.com/articles/setting-the-default-branch/ - pull requests will be created against that branch by default.

@danbri
Contributor
danbri commented Jan 22, 2015

Thanks @scor just what I was looking for! :)

@danbri danbri closed this Jan 22, 2015
@danbri
Contributor
danbri commented Jan 28, 2015

Related - I've updated #53 with a link to the results of re-running this linter against today's version of sdo-stantz: https://gist.github.com/danbri/c5fef76dcf89bc23bdb6

@danbri
danbri commented on 8624f7f Jan 29, 2015

After investigating I'm pretty sure releasedEvent was intended - so I'll close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment