Fix AggregateOffer lossage #209

Closed
wants to merge 2 commits into
from

Projects

None yet

3 participants

@sesuncedu
Contributor

The example microdata is missing a tag.

The domain of schema:offers is missing AggregateOffer (contra the examples); the rich snippets testing tool follows the rdfa and not the examples.

@danbri danbri self-assigned this Jan 22, 2015
@danbri
Contributor
danbri commented Jan 22, 2015

Thanks.

update: (mistaken, see below :)
Regarding domain, we do point to a parent type i.e. Offer. I can't offer a formal proof that it's therefore ok to apply to a subtype but it would seem plausible?

    <http://schema.org/offers> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> <http://www.w3.org/1999/02/22-rdf-syntax-ns#Property> .
    <http://schema.org/offers> <http://www.w3.org/2000/01/rdf-schema#label> "offers" .
    <http://schema.org/offers> <http://schema.org/domainIncludes> <http://schema.org/Product> .
    <http://schema.org/offers> <http://schema.org/domainIncludes> <http://schema.org/Event> .
    <http://schema.org/offers> <http://schema.org/domainIncludes> <http://schema.org/CreativeWork> .
    <http://schema.org/offers> <http://schema.org/rangeIncludes> <http://schema.org/Offer> .
    <http://schema.org/offers> <http://www.w3.org/2000/01/rdf-schema#comment> "An offer to provide this item&#x2014;for example, an offer to sell a product, rent the DVD of a movie, or give away tickets to an event." .
@danbri danbri added this to the 2015 Q1 milestone Jan 22, 2015
@sesuncedu
Contributor

I don't think Offer is in the domain - just the range?

@danbri
Contributor
danbri commented Jan 22, 2015

/me blames his new glasses

You're entirely right. Which is the best kind of right. We should have a branch here shortly for the next release, into which this'll get pulled. Thanks!

@danbri
Contributor
danbri commented Jan 22, 2015

When I stop to think I realise this is the same issue as #141

@danbri
Contributor
danbri commented Jan 22, 2015

@sesuncedu would you mind retargetting these fixes at the sdo-stantz branch?

@danbri
Contributor
danbri commented Jan 22, 2015

Merged via #274

@danbri danbri closed this Jan 22, 2015
@danbri
Contributor
danbri commented Jan 26, 2015

fixes #141

@eldk
eldk commented Feb 20, 2015

Hello,
This seems to be not fixed in google micro-data testing tool
as this is the same as #141, I haved put my comment on this conversation.
Greatings,
Eric

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment