Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified Audiobook example #2232

Merged
merged 11 commits into from Sep 23, 2019

Conversation

@BigBlueHat
Copy link
Contributor

commented Apr 23, 2019

The earlier JSON-LD version looked like it was extracted from the RDFa and had some cruft from that conversion left over. It's gone now, and should be simpler and more easily reused.

BigBlueHat added 5 commits Apr 23, 2019
@BigBlueHat

This comment has been minimized.

Copy link
Contributor Author

commented Apr 23, 2019

Well...I got inspired. 😁 The Audiobook examples now use the url to properly point at the actual Audiobook and mainEntityOfPage to point to the information page about the Audiobook.

I also chose a freely available audiobook from the kind people at Archive.org and LibriVox. It also happens to be Alice's Adventure's in Wonderland because Mad Hatters.

Cheers!
🎩

@RichardWallis

This comment has been minimized.

Copy link
Contributor

commented May 2, 2019

A nice simple example.

I would tweak it slightly thus:

{
  "@context": "http://schema.org/",
  "type": "Audiobook",
  "@id": "https://archive.org/details/alices_adventures_1005_librivox",
  "abridged": "false",
  "author": "Lewis Carroll",
  "description": "Alice's Adventures in Wonderland (commonly shortened to Alice in Wonderland) is an 1865 novel written by English author Charles Lutwidge Dodgson under the pseudonym Lewis Carroll. It tells the story of a girl named Alice who falls down a rabbit hole into a fantasy world populated by peculiar and anthropomorphic creatures. The tale is filled with allusions to Dodgson's friends. The tale plays with logic in ways that have given the story lasting popularity with adults as well as children. It is considered to be one of the best examples of the "literary nonsense" genre, and its narrative course and structure have been enormously influential, especially in the fantasy genre. (Introduction by Wikipedia)",
  "datePublished": "2010-05-03",
  "duration": "PT2H31M21S",
  "encodingFormat": "video/mp4",
  "name": "Alice's Adventures in Wonderland",
  "playerType": "M4B compatible",
  "provider": "The Internet Archive",
  "publisher": "LibriVox",
  "readBy": "Eric Leach",
  "contentUrl": "https://archive.org/download/alices_adventures_1005_librivox/AlicesAdventuresInWonderlandV5_librivox.m4b",
  "mainEntityOfPage": "https://archive.org/details/alices_adventures_1005_librivox"
}

There is a difference between the Audiobook (CreativeWork) and the actual bytes of the media object.

BigBlueHat added 3 commits May 3, 2019
@BigBlueHat

This comment has been minimized.

Copy link
Contributor Author

commented May 3, 2019

@RichardWallis so...this may be a bit Range-14-like, but...

This trimmed example (from your post earlier--and on which I'm basing further commits to this PR) introduces some confusion (at least in my coffee-enhanced cranium):

{
  "@context": "http://schema.org/",
  "type": "Audiobook",
  "@id": "https://archive.org/details/alices_adventures_1005_librivox",
  "contentUrl": "https://archive.org/download/alices_adventures_1005_librivox/AlicesAdventuresInWonderlandV5_librivox.m4b",
  "mainEntityOfPage": "https://archive.org/details/alices_adventures_1005_librivox"
}

That, afaict, says that https://archive.org/details/alices_adventures_1005_librivox is the Audiobook, but that the content of that URL is really at https://archive.org/download/alices_adventures_1005_librivox/AlicesAdventuresInWonderlandV5_librivox.m4b (which is one format/expression of the conceptual Audiobook) and that the "main entity" of https://archive.org/details/alices_adventures_1005_librivox is itself...

I realize that "naming things is hard," but I wanted to double check with you (et al) prior to making these changes.

This is more or less why I'd used url earlier and not @id or contentUrl, but again...I acknowledge this gets a bit Range-14 like...so input welcome! 😁

@BigBlueHat

This comment has been minimized.

Copy link
Contributor Author

commented May 7, 2019

To avoid this being stalled indefinitely, @RichardWallis how do you feel about my removing the @id (leaving it unidentified...), but leave all the others in place?

@RichardWallis

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

To avoid confusion, either the @id value or the mainEntityOfPage value, should be removed or modified. (not that having the same URI for the page and the entity that describes it is implicitly wrong)

My personal preference would to either change the @id value to something like https://archive.org/details/alices_adventures_1005_librivox#work or to drop the mainEntityOfPage value.

To my mind it is more important to identify the thing/entity than the page(s) that may represent it. Having said that, out in the real world it is often the case that the page URL is the only available identifier.

@BigBlueHat

This comment has been minimized.

Copy link
Contributor Author

commented Jun 10, 2019

@RichardWallis sorry for the wait on this one. I went with the #work suffix option. Please let me know if it needs anything else!

@danbri

This comment has been minimized.

Copy link
Contributor

commented Sep 23, 2019

Github is reporting conflicts in data/ext/bib/bsdo-audiobook-examples.txt - could you take a look?

@danbri danbri merged commit 27f037b into schemaorg:master Sep 23, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.