Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed inconsistencies in expected types for Date & Time expecting properties #2273

Merged
merged 2 commits into from Jun 18, 2019

Conversation

Projects
None yet
4 participants
@RichardWallis
Copy link
Contributor

commented Jun 13, 2019

Added Date to rangeInclude for orderDate, validFrom, validThrough, paymentDueDate, expectedArrivalFrom, expectedArrivalUntil, dateRead, availabilityStarts, availabilityEnds, dateDeleted, dateIssued.

Added Time to the rangeIncludes for checkoutTime, checkinTime, checkinTime, arrivalTime,
departureTime, availabilityStarts, availabilityEnds, doorTime, endTime, startTime.
Fix for issue #(2271)

Added Date to rangeincluded for orderDate, validFrom, validThrough, p…
…aymentDueDate,

expectedArrivalFrom, expectedArrivalUntil, dateRead, availabilityStarts,
availabilityEnds, dateDeleted, dateIssued
and Time to the rangeIncludes for checkoutTime, checkinTime, checkinTime, arrivalTime,
departureTime, doorTime, endTime, startTime.
Fix for issue #(2271)
@gkellogg

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2019

From the Travis run, it looks like there's more low-hanging fruit:

  • availabilityStarts – include Time in range
  • availabilityEnds – include Time in range

@danbri danbri merged commit 23bde9b into master Jun 18, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.