Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further corrections to examples identified as errors by Travis CI scripts #2285

Merged
merged 44 commits into from Jul 16, 2019

Conversation

@RichardWallis
Copy link
Contributor

@RichardWallis RichardWallis commented Jun 18, 2019

Results of a concentrated effort to reduce the number of errors reported by Travis CI tests when checking examples files.

Following previous efforts in this area (#2189) files from all sections are now checked.

Many individual changes/fixes to example syntax, both HTML & Schema.org, reduced number of errors reported down from 120 to a total of 45.

More work to do!

Dataliberate added 30 commits Jun 13, 2019
@gkellogg
Copy link
Contributor

@gkellogg gkellogg commented Jun 19, 2019

Looking good, once you get them down to 0, we can change the Ruby tests to fail on error, making the whole PR system work much better at keeping errors from being introduced.

Loading

@RichardWallis RichardWallis merged commit bff6dd1 into master Jul 16, 2019
2 checks passed
Loading
@RichardWallis RichardWallis deleted the examplesfix2 branch Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants