Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes typo for rdfs:label URI in schema.rdfa #2312

Merged
merged 1 commit into from Sep 23, 2019

Conversation

@Tpt
Copy link
Contributor

commented Jul 19, 2019

The rdfs:label value was used for the href attribute.

It was leading to the generation of the triple schema:name rdfs:subPropertyOf <rdfs:label> instead of schema:name rdfs:subPropertyOf rdfs:label (the rdfa parsers do not resolve namespace prefixes in the href attribute value).

"rdfs:label" was used as value for the href attribute.
It was leading to the generation of the triple "schema:name rdfs:subPropertyOf <rdfs:label>"
instead of "schema:name rdfs:subPropertyOf rdfs:label"
(the rdfa parsers do not resolve namespace prefixes in the "href" attribute value).
@Tpt

This comment has been minimized.

Copy link
Contributor Author

commented Jul 19, 2019

The CI error does not seem related to this PR

@RichardWallis

This comment has been minimized.

Copy link
Contributor

commented Jul 19, 2019

@Tpt You are correct the CI error is not connected with this PR - I am working on a fix.

As to the PR itself, as our parser in the Schema.org site is fine with it it obviously hadn't shown up previously.

@RichardWallis

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2019

@Tpt the CI error now fixed

@Tpt

This comment has been minimized.

Copy link
Contributor Author

commented Jul 25, 2019

@RichardWallis great! Thank you!

@danbri danbri merged commit f3f0295 into schemaorg:master Sep 23, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Tpt Tpt deleted the Tpt:patch-3 branch Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.