Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing domain and range of eventSchedule property #2388

Merged
merged 1 commit into from Jan 2, 2020
Merged

Fixing domain and range of eventSchedule property #2388

merged 1 commit into from Jan 2, 2020

Conversation

thill-odi
Copy link
Contributor

@thill-odi thill-odi commented Nov 6, 2019

Related to issue #2277 - though there's a discrepancy between the error reported from Travis (type expected is EventSchedule) and the problem identified (domain is given as Schedule and range as Duration)

@RichardWallis RichardWallis marked this pull request as ready for review Nov 6, 2019
@danbri danbri mentioned this pull request Nov 6, 2019
16 tasks
@thill-odi thill-odi closed this Nov 6, 2019
@thill-odi thill-odi reopened this Nov 6, 2019
@RichardWallis
Copy link
Contributor

@RichardWallis RichardWallis commented Nov 11, 2019

Snippet for Site Improvements section of releases.html:

<li id="2277"><a href="https://github.com/schemaorg/schemaorg/issues/2277">Issue #2277</a>:
(implemented in <a href="https://github.com/schemaorg/schemaorg/pull/2388">PR #2388</a>):
Fixed error in definition of <a href="/eventSchedule">eventSchedule</a> property.
</li>

@ldodds
Copy link
Contributor

@ldodds ldodds commented Nov 22, 2019

Anything else to do for this to be merged @RichardWallis?

@danbri danbri merged commit 45bfcdb into schemaorg:master Jan 2, 2020
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants