-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebAPI update based on #1423 #2635
base: main
Are you sure you want to change the base?
Conversation
Is the context still just |
Thanks for your feedback - We went with |
Looking at #2597, the https change now looks imminent - so perhaps good to stick with this in here? |
When is something appropriate for endpointDescription and/or conformsTo?
…On Wed, Aug 12, 2020, 6:24 AM Nick Evans ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In data/ext/pending/issue-1423.ttl
<#2635 (comment)>:
> + :category "issue-1423" ;
+ :domainIncludes :WebAPI ;
+ :isPartOf <http://pending.schema.org> ;
+ :rangeIncludes :EntryPoint,
+ :URL ;
+ :source <#1423> ;
+ rdfs:comment "The root location or primary endpoint of the API." .
+
+:conformsTo a rdf:Property ;
+ rdfs:label "conformsTo" ;
+ :category "issue-1423" ;
+ :domainIncludes :WebAPI ;
+ :isPartOf <http://pending.schema.org> ;
+ :rangeIncludes :URL ;
+ :source <#1423> ;
+ rdfs:comment "The URL reference of an established standard to which the described API conforms, for example `https://jsonapi.org/format/1.0/` <https://jsonapi.org/format/1.0/>, `https://grpc.io/` <https://grpc.io/>, or `http://www.hydra-cg.com/spec/latest/core/` <http://www.hydra-cg.com/spec/latest/core/>." .
The idea with these examples is to show the breadth of conformsTo - it is
not limited to just API specifications, but indeed any applicable standard
or specification.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2635 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAMNS2FQEEGYKLAFVGOPFDSAJUVLANCNFSM4OS5RCWQ>
.
|
@westurner see the documentation included in this PR: schemaorg/data/ext/pending/issue-1423.ttl Line 41 in c0dabcd
Also see notes here for the derivation: https://webapi-discovery.github.io/rfcs/rfc0001.html#new-property-endpointdescription This distinction is taken verbatim straight out of DCAT v2, see https://www.w3.org/TR/vocab-dcat-2/#Property:data_service_endpoint_description |
Is there already an example (edit: in the schrma.org spec) where both are specified?
…On Wed, Aug 12, 2020, 11:45 AM Nick Evans ***@***.***> wrote:
@westurner <https://github.com/westurner> see the documentation included
in this PR:
https://github.com/schemaorg/schemaorg/blob/c0dabcdf099622e4b93375e06c8900e6ca96303f/data/ext/pending/issue-1423.ttl#L41
Also see notes here for the derivation:
https://webapi-discovery.github.io/rfcs/rfc0001.html#new-property-endpointdescription
This distinction is taken verbatim straight out of DCAT v2, see
https://www.w3.org/TR/vocab-dcat-2/#Property:data_service_endpoint_description
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2635 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAMNS7X6CUKWK4Z5SNHWYDSAK2KZANCNFSM4OS5RCWQ>
.
|
Yep, the main comprehensive example covers both, though in fairness the example data is not accurate (i.e. the Google Knowledge Graph Search API does not comply with JSON:API, or any specific wider standard/spec that I could identify?). We'd likely have to use a different API in the example if we wanted it to include accurate data... schemaorg/data/ext/pending/issue-1423-examples.txt Lines 58 to 69 in c0dabcd
schemaorg/data/ext/pending/issue-1423-examples.txt Lines 104 to 106 in c0dabcd
|
While I'm sure it's not possible to satisfy every combination, it may be most helpful to include examples of at least these relatively common and/or linked data APIs:
If there aren't Enumerations of the common specs, there's not likely to be any consistency in how people cite which version of the specs the API implements; so examples to copy/paste might make adoption easier and more likely |
Sure @westurner, this sounds like a good addition - either in this PR or a subsiquent PR to improve example coverage. REST is already covered, however would you be able to create some examples for SPARQL, GraphQL, and LDP? It sounds like if we don't have time to do this right now it could easily go into a subsequent PR, as the comprehensive example we have already gives people a pretty solid steer, so no rush here, but agreed more examples are always good. |
I'll add this to my queue. I agree that this can be done later |
Note the gRPC and Hydra examples have been removed from |
Additionally have simplified references to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the property called 'endpointUrl'? isn't it just a property whose value is the endpoint (an 'EntryPoint') that might have an 'url' property of its own?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the /conformsTo comment - see also #1516 for the case to add it more generally than just for APIs. Replace mention of API with "to which the thing described conforms. Broadly equivalent to Dublin Core's "conformsTo" property - https://www.dublincore.org/specifications/dublin-core/dcmi-terms/#http://purl.org/dc/terms/conformsTo. We should set domainIncludes to at least /CreativeWork, possibly wider later.
Included in commit c90261b. @danbri is that what you meant, or shall we remove the reference to Dublin Core from the description? |
So there are a few reasons for this:
Alternative names include:
However depending on the API, the value could represent the base URL or primary endpoint... hence @danbri interested in your thoughts? |
@danbri I've removed references to It appears we have consensus on everything else. |
This pull request is being tagged as Stale due to inactivity. |
@danbri just nudging this, seems like it's just a case of you confirming you're happy with the above? #2635 (comment) |
@danbri also popping in to ask if there's anything we can do to get this moving again? Very keen to get |
Another nudge on this @danbri - what are the next steps here? |
why is this languishing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Knowledge Graph Search API (https://kgsearch.googleapis.com) no longer exists. It was shut down as an external API a few years ago. This WebAPI change needs to be reworked with another example. If you want to stick with Google, I suggest the YouTube API (https://developers.google.com/youtube/v3)
As requested by @danbri in #1423 (comment), and in consultation with @MikeRalphson as per discussion in webapi-discovery/rfcs#6, this PR implements the latest recommendations from the W3C WebAPI Discovery Community Group.
See https://webapi-discovery.github.io/rfcs/rfc0001.html for the rationale behind these proposed changes.