Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 2636 create PracticeProblem schema #2642

Closed
wants to merge 9 commits into from

Conversation

@lucy-kind
Copy link
Contributor

@lucy-kind lucy-kind commented Jul 9, 2020

Create PracticeProblem type, and add hasPart property to existing Quiz and Course types with value of PracticeProblem.

For #2636

lucy-kind and others added 7 commits May 12, 2020
update to merge with schema.org
merge master changes into fork
merge updates from master
merge master from schema.org
Create PracticeProblem type with properties hasPart and problemType; add hasPart as property to Quiz and Course types.
Tested in http://www.easyrdf.org/converter

Line 25 ended with "," instead of ";"
Fixed some minor wording, and removed leading whitespace.
Copy link
Contributor

@danbri danbri left a comment

I've fixed some minor errors in the first sections that introduce new terms.

For the last two sections, I am confused. It looks like you're defining a new term :hasPart, but this already exists in Schema.org, and already is expected between any kinds of creative works. I think you can deleted these:

:hasPart a rdf:Property ;
    rdfs:label "hasPart" ;
    :category "issue-2636" ;
    :domainIncludes :PracticeProblem ;
    :isPartOf <http://pending.schema.org> ;
    :rangeIncludes :Question ;
    :source <https://github.com/schemaorg/schemaorg/issues/2636> ;
    rdfs:comment "Designates that it contains a creative work." .

:hasPart a rdf:Property ;
    rdfs:label "hasPart" ;
    :category "issue-2636" ;
    :domainIncludes :Quiz,
        :Course ;
    :isPartOf <http://pending.schema.org> ;
    :rangeIncludes :PracticeProblem ;
    :source <https://github.com/schemaorg/schemaorg/issues/2636> ;
    rdfs:comment "Designates that it contains a creative work." .```

In general, Schema.org definitions are additive. You have to consider any assertions you make in data/ext/pending/*.ttl files as being overlaid on top of what we already have in data/schema.ttl core definitions. So here you're just attaching more properties to hasPart that will just collide with the existing rdfs:comment etc. Or was the intent to somehow highlight /hasPart as being particularly relevant to /Question?
@lucy-kind
Copy link
Contributor Author

@lucy-kind lucy-kind commented Jul 10, 2020

hasPart ttl code removed; also added examples file!

@lucy-kind lucy-kind closed this Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants