Skip to content

issue 2636: Create eduQuestionType for questions that act as practice problems #2663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jul 23, 2020

Conversation

lucy-kind
Copy link
Contributor

Update issue 2636 (see discussion on issue)

lucy-kind and others added 13 commits May 12, 2020 10:48
update to merge with schema.org
merge master changes into fork
merge updates from master
merge master from schema.org
Create PracticeProblem type with properties hasPart and problemType; add hasPart as property to Quiz and Course types.
Tested in http://www.easyrdf.org/converter

Line 25 ended with "," instead of ";"
Fixed some minor wording, and removed leading whitespace.
add example for PracticeProblem
update to new schema for issue 2636 (discussion on issue page)
Example of quiz with a question that is a learning resource type of Practice Problem.
update e.g. in description
update eduQuestionType
@RichardWallis RichardWallis changed the base branch from master to main July 23, 2020 13:01
Copy link
Contributor

@danbri danbri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments

"@type": "Answer",
"@id": "http://example.org/fractions/practice-problem#answer_2",
"encodingFormat": "text/html",
"text": "<img src=\"www.test.com/practice-problems-fractions/…image2.png\" alt=\"Answer 2\" />"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this terrifying thing? :)

HTML inside a JSON(-LD) "text" field, itself likely already inside HTML via <script>. If the goal is to work out how to put small pieces of HTML inside Schema.org graphs, that seems a reasonable goal, but I don't think this combination of /encodingFormat and /text really work. The /text field isn't a good place for complex computer formats. Sorry if I missed this when we talked through this proposal recently.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are various ways we could put chunks of HTML inside the schema.org graph datamodel:

  • items in the graph could have an /asHTML property pointing to an instance of the existing /WebPageElement type, and then the actual markup could be a /rawHTMLText property from that (or similar names)
  • alternatively, just have /rawHTMLText on items in the graph, like the /Answer (this would be simpler than trying to pair /encodingFormat and /text)

/cc @vholland @rvguha

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need the HTML inside the graph when the JSON-LD is inside the HTML? You have a fragment id there, why not put the answer in the HTML wrapped in <div id="answer_2"></div> That's what we did for K12-OCX (there are analagous examples at the end)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@philbarker this is the approach used around SpeakableSpecification. It can be made to work but it is difficult in environments that parse triples out of pages and lose touch with the original context.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, talking to @lucy-kind and colleagues, we'll retract this bit of the example for now and come up with another idiom

Fixed quoting of quotes using quote-quote-quote quotes
"@type": "Answer",
"@id": "http://example.org/fractions/practice-problem#answer_2",
"encodingFormat": "text/html",
"text": "<img src=\"www.test.com/practice-problems-fractions/…image2.png\" alt=\"Answer 2\" />"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@philbarker this is the approach used around SpeakableSpecification. It can be made to work but it is difficult in environments that parse triples out of pages and lose touch with the original context.

"@type": "Answer",
"@id": "http://example.org/fractions/practice-problem#answer_2",
"encodingFormat": "text/html",
"text": "<img src=\"www.test.com/practice-problems-fractions/…image2.png\" alt=\"Answer 2\" />"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, talking to @lucy-kind and colleagues, we'll retract this bit of the example for now and come up with another idiom

Removing the example for now - will reformulate

https://gist.github.com/danbri/6373de64dd9820a25aba0d6dd52799b0 has a snapshot
@danbri
Copy link
Contributor

danbri commented Jul 23, 2020

ok, after discussion - example removed for now. I put a copy in https://gist.github.com/danbri/6373de64dd9820a25aba0d6dd52799b0 so the discussion makes sense to subsequent readers.

@danbri danbri merged commit 77f7790 into schemaorg:main Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants