Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 851: a parentItem of a Comment should be Comment, not Question #2664

Merged
merged 3 commits into from Jul 23, 2020

Conversation

lucy-kind
Copy link
Contributor

@lucy-kind lucy-kind commented Jul 21, 2020

a parentItem of a Comment should be Comment, not Question. planned for v10 release (see issue #2648)

(edited to write " issue 2648" with a # in it so it gets automatically linked to the issue by github --danbri)

a parentItem of a Comment should be Comment, not Question. planned for v10 release (see issue 2648)
@RichardWallis
Copy link
Contributor

@lucy-kind - you edited the wrong file - data/releases/9.0/schema.ttl is a release specific copy we make of the file you need to edit which is data/schema.ttl.

~Richard

update parentItem
revert release file
@lucy-kind
Copy link
Contributor Author

Hi Richard, first time editing the core file; thank you for the info! I've reverted the version file and edited the one you pointed to.

@RichardWallis RichardWallis changed the base branch from master to main July 23, 2020 12:59
@danbri
Copy link
Contributor

danbri commented Jul 23, 2020

Thanks @lucy-kind, @RichardWallis - merging! Great to fix this old bug.

@danbri danbri merged commit 1a7f3df into main Jul 23, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants