Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #2646: Added AmpStory #2719

Merged
merged 2 commits into from Sep 30, 2020
Merged

Issue #2646: Added AmpStory #2719

merged 2 commits into from Sep 30, 2020

Conversation

vholland
Copy link
Contributor

No description provided.

@RichardWallis
Copy link
Contributor

Checks are failing on this PR.

Bit of an odd failure:

INFO:test_graphs:Term 'http://schema.org/EducationalOccupationalProgram' has none-matching label: 'AmpStory'
FAIL

@vholland
Copy link
Contributor Author

Oops. I fixed it. And now everyone knows I mostly code by copy & paste.

@danbri
Copy link
Contributor

danbri commented Sep 30, 2020

@vholland could you PR something for docs/releases.html too?

@danbri
Copy link
Contributor

danbri commented Sep 30, 2020

or just type it here :)

@danbri danbri merged commit 61c4b33 into schemaorg:main Sep 30, 2020
@danbri
Copy link
Contributor

danbri commented Sep 30, 2020

I've merged this, but suggest we consider prepending something referencing https://wp.stories.google/ into "A creative work with a visual storytelling format intended to be viewed online, particularly on mobile devices."

more details at https://amp.dev/documentation/components/amp-story/#metadata-guidelines

Those docs describe a custom element <amp-story> which gives us a good technical reference at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants