Skip to content

Issue #2646: Added AmpStory - #2719

Merged
danbri merged 2 commits into
schemaorg:mainfrom
vickitardif:ampstory
Sep 30, 2020
Merged

danbri merged 2 commits into
schemaorg:mainfrom
vickitardif:ampstory

Conversation

@vickitardif

Copy link
Copy Markdown
Contributor

No description provided.

@RichardWallis

Copy link
Copy Markdown
Contributor

Checks are failing on this PR.

Bit of an odd failure:

INFO:test_graphs:Term 'http://schema.org/EducationalOccupationalProgram' has none-matching label: 'AmpStory'
FAIL

@vickitardif

Copy link
Copy Markdown
Contributor Author

Oops. I fixed it. And now everyone knows I mostly code by copy & paste.

@danbri

danbri commented Sep 30, 2020

Copy link
Copy Markdown
Contributor

@VHolland could you PR something for docs/releases.html too?

@danbri

danbri commented Sep 30, 2020

Copy link
Copy Markdown
Contributor

or just type it here :)

@danbri
danbri merged commit 61c4b33 into schemaorg:main Sep 30, 2020
@danbri

danbri commented Sep 30, 2020

Copy link
Copy Markdown
Contributor

I've merged this, but suggest we consider prepending something referencing https://wp.stories.google/ into "A creative work with a visual storytelling format intended to be viewed online, particularly on mobile devices."

more details at https://amp.dev/documentation/components/amp-story/#metadata-guidelines

Those docs describe a custom element <amp-story> which gives us a good technical reference at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants