Skip to content

Draft for structured product sizes (issue #2811) #2819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danbri merged 1 commit into from
Jan 26, 2021
Merged

Draft for structured product sizes (issue #2811) #2819

danbri merged 1 commit into from
Jan 26, 2021

Conversation

@alex-jansen
Copy link
Contributor

@alex-jansen alex-jansen commented Jan 24, 2021 •
edited by danbri
Loading

For issue #2811

@alex-jansen alex-jansen requested review from danbri and mfhepp January 24, 2021 11:04
@danbri danbri self-assigned this Jan 26, 2021
danbri
danbri approved these changes Jan 26, 2021
View reviewed changes
Copy link
Contributor

@danbri danbri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will merge this now and push to webschemas.org, to aid review/feedback process. If nobody finds issues we can push it out as part of Pending in the next release. /cc @mfhepp

@danbri danbri merged commit f64a8d9 into main Jan 26, 2021
@MatthiasWiesmann MatthiasWiesmann deleted the sizes branch September 16, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danbri danbri danbri approved these changes

@mfhepp mfhepp Awaiting requested review from mfhepp

Assignees

@danbri danbri

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alex-jansen @danbri