Skip to content

Implementation of GitHub Actions based continuous integration tests #2836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Feb 14, 2021

Conversation

RichardWallis
Copy link
Contributor

Re Issue #2835

Removal of .travis.yml Travis-CI integration file

Replaced with ci_tests.yml file in .github/workflows

@RichardWallis
Copy link
Contributor Author

Tests run in less than 5 mins - signifiant improvement over Travis-CI.org

/cc @gkellogg
Everything Ruby appears to be running the same in this environment -could you have a conformationary look

@RichardWallis RichardWallis merged commit 2bf9ac9 into main Feb 14, 2021
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: 2.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update this to at least Ruby 2.8, if not 3.0.

- name: Install Ruby dependencies
run: |
gem update --system --conservative || (gem i "rubygems-update:~>2.7" --no-document && update_rubygems)
gem update bundler --conservative
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This two steps are probably not necessary, any longer.

- name: Run Ruby tests
run: (cd software/scripts; bundle exec rake)
env:
SOFT_LINT: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With a relatively low number of failures, we could go to a black-list model to mark those tests expected to fail, which would then be useful to note when those tests pass, and to make sure that newly introduced examples pass before being merged.

@RichardWallis
Copy link
Contributor Author

@gkellogg
Thanks for the reviews.
If I create an issue to implement these would it be OK to assign it to you?

@gkellogg
Copy link
Contributor

Sure, I'll take a crack at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants