Make Drug and DietarySupplement inherit from Product. #3094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes them inherit the `manufacturer` field, as well as other relevant fields like `gtin` and `countryOfOrigin`.
|
This pull request is being nudged due to inactivity. |
github-actions
bot
added
the
no-pr-activity
|
Gentle Ping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Bug #3069
Both Drug and DietarySupplement are products, in fact DietarySupplement is described as such: A product taken by mouth that contains a dietary ingredient intended to supplement the diet.
Remove the manufacturer field definition, as it is not needed anymore, that property is inherited from Product.
This also means that both
DietarySupplementandDruginherit relevant fields likegtin,countryOfOriginoroffer.