New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced meta tags with link tags for issue #77 #511

Merged
merged 2 commits into from Apr 24, 2016

Conversation

Projects
None yet
3 participants
@stuartrobinson
Contributor

stuartrobinson commented May 19, 2015

Changes to address the following issue:

#77

@danbri

This comment has been minimized.

Show comment
Hide comment
@danbri

danbri May 19, 2015

Contributor

Thanks! Should these be @content or @href?

Contributor

danbri commented May 19, 2015

Thanks! Should these be @content or @href?

@stuartrobinson

This comment has been minimized.

Show comment
Hide comment
@stuartrobinson

stuartrobinson May 19, 2015

Contributor

I think they should actually be @href. Let me update the branch.

On Tue, May 19, 2015 at 2:32 PM, Dan Brickley notifications@github.com
wrote:

Thanks! Should these be @content https://github.com/content or @href
https://github.com/href?


Reply to this email directly or view it on GitHub
#511 (comment).

Contributor

stuartrobinson commented May 19, 2015

I think they should actually be @href. Let me update the branch.

On Tue, May 19, 2015 at 2:32 PM, Dan Brickley notifications@github.com
wrote:

Thanks! Should these be @content https://github.com/content or @href
https://github.com/href?


Reply to this email directly or view it on GitHub
#511 (comment).

@unor

This comment has been minimized.

Show comment
Hide comment
@unor

unor Feb 26, 2016

Contributor

+1 for the changes to data/examples.txt (the RDFa needs these fixes, too, but this could come at a later point).

The issues in data/sdo-website-examples.txt seem to have been fixed in the meantime (nitpick for the current version: the url value for the Microdata example should be http://example.com/ instead of http://www.example.com/, to be the same like in RDFa and JSON-LD).

Contributor

unor commented Feb 26, 2016

+1 for the changes to data/examples.txt (the RDFa needs these fixes, too, but this could come at a later point).

The issues in data/sdo-website-examples.txt seem to have been fixed in the meantime (nitpick for the current version: the url value for the Microdata example should be http://example.com/ instead of http://www.example.com/, to be the same like in RDFa and JSON-LD).

@danbri danbri merged commit 1034830 into schemaorg:sdo-ganymede Apr 24, 2016

@danbri

This comment has been minimized.

Show comment
Hide comment
@danbri

danbri Apr 24, 2016

Contributor

Belatedly fixed and merged, including the s/www.example.com/example.com/ caught here by @unor. Thanks both!

Contributor

danbri commented Apr 24, 2016

Belatedly fixed and merged, including the s/www.example.com/example.com/ caught here by @unor. Thanks both!

danbri added a commit that referenced this pull request Apr 24, 2016

@danbri

This comment has been minimized.

Show comment
Hide comment
@danbri

danbri Apr 24, 2016

Contributor

Merged to wrong branch, reverting and committing manually. Apologies for the noise and thanks again!

Contributor

danbri commented Apr 24, 2016

Merged to wrong branch, reverting and committing manually. Apologies for the noise and thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment