Replaced meta tags with link tags for issue #77 #511

Merged
merged 2 commits into from Apr 24, 2016

Projects

None yet

3 participants

@stuartrobinson
Contributor

Changes to address the following issue:

#77

@danbri
Contributor
danbri commented May 19, 2015

Thanks! Should these be @content or @href?

@stuartrobinson
Contributor

I think they should actually be @href. Let me update the branch.

On Tue, May 19, 2015 at 2:32 PM, Dan Brickley notifications@github.com
wrote:

Thanks! Should these be @content https://github.com/content or @href
https://github.com/href?


Reply to this email directly or view it on GitHub
#511 (comment).

@unor
Contributor
unor commented Feb 26, 2016

+1 for the changes to data/examples.txt (the RDFa needs these fixes, too, but this could come at a later point).

The issues in data/sdo-website-examples.txt seem to have been fixed in the meantime (nitpick for the current version: the url value for the Microdata example should be http://example.com/ instead of http://www.example.com/, to be the same like in RDFa and JSON-LD).

@danbri danbri merged commit 1034830 into schemaorg:sdo-ganymede Apr 24, 2016
@danbri
Contributor
danbri commented Apr 24, 2016

Belatedly fixed and merged, including the s/www.example.com/example.com/ caught here by @unor. Thanks both!

@danbri danbri pushed a commit that referenced this pull request Apr 24, 2016
Dan Brickley Fixed example.com URL
Was www.example.org
Thanks @unor via #511
8d93ed8
@danbri
Contributor
danbri commented Apr 24, 2016

Merged to wrong branch, reverting and committing manually. Apologies for the noise and thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment