Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpeningHoursSpecification example: various fixes #533

Merged

Conversation

unor
Copy link
Contributor

@unor unor commented May 23, 2015

  • time elements also for plain markup example
  • using meta instead of time for openingHours (as "Mo,Tu,We,Th,Fr,Sa,Su 09:00-14:00" is not a valid @datetime value, see Examples on openingHours should not use the 'time' element #143)
  • no need for an empty time element for validThrough, as @itemprop/@property can have multiple properties
  • JSON-LD example had different data than the markup examples, and the second OpeningHoursSpecification was missing

@unor unor changed the title Fixes to OpeningHoursSpecification example Fixes for OpeningHoursSpecification example May 23, 2015
@unor unor changed the title Fixes for OpeningHoursSpecification example OpeningHoursSpecification example: various fixes May 23, 2015
@danbri danbri merged commit 1e79737 into schemaorg:sdo-ganymede Apr 24, 2016
danbri added a commit that referenced this pull request Apr 24, 2016
@danbri
Copy link
Contributor

danbri commented Apr 24, 2016

@unor - I merged this into sdo-ganymede rather than sdo-deimos without thinking. Fixing manually with a new pull request to sdo-deimos that has conflicts. Possibly these have been fixed already at least in part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants