Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add accessibility example to relevant properties #633

Merged
merged 3 commits into from Jul 8, 2015

Conversation

chaals
Copy link
Contributor

@chaals chaals commented Jul 3, 2015

Might as well show it there

@chaals
Copy link
Contributor Author

chaals commented Jul 3, 2015

Hopefully this makes the example we have of using the accessibility markup show up for each of the accessibility properties that it demonstrates

@chaals chaals added guidelines docs examples Work on our supporting materials rather than on schema definitions type:cleanup + clarity Addresses wording fixes, ambiguities, confusion, bad examples etc labels Jul 3, 2015
based on some slides.
@danbri
Copy link
Contributor

danbri commented Jul 3, 2015

"hopefully"? care to test it locally? You need AppEngine SDK + Python, it is relatively painless...

@chaals
Copy link
Contributor Author

chaals commented Jul 3, 2015

I'll make a µdata example some time next week, in exchange for not testing it at least until then...

@danbri
Copy link
Contributor

danbri commented Jul 3, 2015

deal :) I might have a go too...

micro data for the example I added last, a new example showing scoping
to a particular piece
@chaals
Copy link
Contributor Author

chaals commented Jul 5, 2015

Added a scoped example to deal with questions people have.

I might wait until this gets merged before further additions...

danbri added a commit that referenced this pull request Jul 8, 2015
add accessibility example to relevant properties
@danbri danbri merged commit b2facf7 into schemaorg:sdo-ganymede Jul 8, 2015
@danbri
Copy link
Contributor

danbri commented Jul 8, 2015

Merged. Examples look good :) nice to have property pages with better examples...

@danbri
Copy link
Contributor

danbri commented Jul 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
guidelines docs examples Work on our supporting materials rather than on schema definitions type:cleanup + clarity Addresses wording fixes, ambiguities, confusion, bad examples etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants