New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PropertyValue example fixes (pre-markup ex. had Microdata; alt attributes were missing) #836

Merged
merged 2 commits into from Mar 18, 2016

Conversation

Projects
None yet
4 participants
@unor
Contributor

unor commented Oct 6, 2015

  • removed Microdata from two PRE-MARKUP examples
  • added empty alt attribute to all img elements

(@danbri: Should I create an issue for this? I assumed not because these are only example markup changes.)

@unor unor changed the title from PropertyValue example fixes to PropertyValue example fixes (pre-markup ex. had Microdata; alt attributes were missing) Oct 6, 2015

@chaals

This comment has been minimized.

Show comment
Hide comment
@chaals

chaals Oct 6, 2015

Looks OK to me… It would be better to use figure/figurecaption in this case but I think we can live without that until someone has time

chaals commented on efeb7d7 Oct 6, 2015

Looks OK to me… It would be better to use figure/figurecaption in this case but I think we can live without that until someone has time

@mfhepp

This comment has been minimized.

Show comment
Hide comment
@mfhepp

mfhepp Oct 7, 2015

Contributor

+1 !
Thanks for spotting and fixing this. Should go into sdo-phobos if posssible.

Contributor

mfhepp commented Oct 7, 2015

+1 !
Thanks for spotting and fixing this. Should go into sdo-phobos if posssible.

danbri added a commit that referenced this pull request Mar 18, 2016

Merge pull request #836 from unor/propertyvalue-example-fixes
PropertyValue example fixes (pre-markup ex. had Microdata; alt attributes were missing)

@danbri danbri merged commit 05b43cf into schemaorg:sdo-phobos Mar 18, 2016

danbri added a commit that referenced this pull request Mar 18, 2016

@danbri

This comment has been minimized.

Show comment
Hide comment
@danbri

danbri Mar 18, 2016

Contributor

@unor - I see that I just merged this by mistake into the old sdo-phobos branch. Would you mind re-targetting it at sdo-deimos? Otherwise I can figure it out from my side but I believe Github makes such things easier from the PR proposer.

Contributor

danbri commented Mar 18, 2016

@unor - I see that I just merged this by mistake into the old sdo-phobos branch. Would you mind re-targetting it at sdo-deimos? Otherwise I can figure it out from my side but I believe Github makes such things easier from the PR proposer.

@unor

This comment has been minimized.

Show comment
Hide comment
@unor

unor Mar 18, 2016

Contributor

@danbri: The new one is #1037

Contributor

unor commented Mar 18, 2016

@danbri: The new one is #1037

danbri added a commit that referenced this pull request Mar 19, 2016

Merge pull request #1037 from unor/propertyvalue-example-fixes
PropertyValue example fixes (pre-markup ex. had Microdata; alt attributes were missing) [supersedes #836]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment