PropertyValue example fixes (pre-markup ex. had Microdata; alt attributes were missing) #836

Merged
merged 2 commits into from Mar 18, 2016

Projects

None yet

4 participants

@unor
Contributor
unor commented Oct 6, 2015
  • removed Microdata from two PRE-MARKUP examples
  • added empty alt attribute to all img elements

(@danbri: Should I create an issue for this? I assumed not because these are only example markup changes.)

@unor unor changed the title from PropertyValue example fixes to PropertyValue example fixes (pre-markup ex. had Microdata; alt attributes were missing) Oct 6, 2015
@chaals
chaals commented on efeb7d7 Oct 6, 2015

Looks OK to me… It would be better to use figure/figurecaption in this case but I think we can live without that until someone has time

@mfhepp
Contributor
mfhepp commented Oct 7, 2015

+1 !
Thanks for spotting and fixing this. Should go into sdo-phobos if posssible.

@danbri danbri merged commit 05b43cf into schemaorg:sdo-phobos Mar 18, 2016
@danbri danbri pushed a commit that referenced this pull request Mar 18, 2016
Dan Brickley Noted markup fixes in #836 a651c87
@danbri
Contributor
danbri commented Mar 18, 2016

@unor - I see that I just merged this by mistake into the old sdo-phobos branch. Would you mind re-targetting it at sdo-deimos? Otherwise I can figure it out from my side but I believe Github makes such things easier from the PR proposer.

@unor
Contributor
unor commented Mar 18, 2016

@danbri: The new one is #1037

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment