New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix899 #901

Merged
merged 2 commits into from Nov 26, 2015

Conversation

Projects
None yet
3 participants
@RichardWallis
Contributor

RichardWallis commented Nov 19, 2015

Fix to #899 - Fix to ShortenOnSentence() which failed on comment string over max length which did not end with '.'. For completeness, added the missing '.' to definition of vehicleSeatingCapacity property.

Also Disabled _siteDebug call on host schema.org unless PRODSITEDEBUG environment variable set to 'True'. Still operates as before on all other hosts.

RichardWallis added some commits Nov 19, 2015

Dissabled _siteDebug call on host schema.org unless PRODSITEDEBUG env…
…ironment variable set to 'True'. Sitll operates on all other hosts.
Fix (#899) 500 error for term 'vehicleSeatingCapacity'
Fix to ShortenOnSentence() which failed on comment sting over max length which did not end with '.'.  For completenes, added the missing '.' to definition of vehicleSeatingCapacity property.

danbri added a commit that referenced this pull request Nov 26, 2015

@danbri danbri merged commit 1d4639a into master Nov 26, 2015

@danbri

This comment has been minimized.

Show comment
Hide comment
@danbri

danbri Nov 26, 2015

Contributor

Ok let's get this released 'early access'...

Contributor

danbri commented Nov 26, 2015

Ok let's get this released 'early access'...

@RichardWallis

This comment has been minimized.

Show comment
Hide comment
@RichardWallis

RichardWallis Nov 26, 2015

Contributor

Yup - you going to do that - and update deimos to bring it into step?

~Richard.

On Thu, Nov 26, 2015 at 6:46 PM, Dan Brickley notifications@github.com
wrote:

Ok let's get this released 'early access'...


Reply to this email directly or view it on GitHub
#901 (comment).

Contributor

RichardWallis commented Nov 26, 2015

Yup - you going to do that - and update deimos to bring it into step?

~Richard.

On Thu, Nov 26, 2015 at 6:46 PM, Dan Brickley notifications@github.com
wrote:

Ok let's get this released 'early access'...


Reply to this email directly or view it on GitHub
#901 (comment).

@danbri

This comment has been minimized.

Show comment
Hide comment
@danbri

danbri Nov 27, 2015

Contributor

I will! Thanks for the fix.

On Thu, Nov 26, 2015 at 11:05 PM RichardWallis notifications@github.com
wrote:

Yup - you going to do that - and update deimos to bring it into step?

~Richard.

On Thu, Nov 26, 2015 at 6:46 PM, Dan Brickley notifications@github.com
wrote:

Ok let's get this released 'early access'...


Reply to this email directly or view it on GitHub
<#901 (comment)
.


Reply to this email directly or view it on GitHub
#901 (comment).

Contributor

danbri commented Nov 27, 2015

I will! Thanks for the fix.

On Thu, Nov 26, 2015 at 11:05 PM RichardWallis notifications@github.com
wrote:

Yup - you going to do that - and update deimos to bring it into step?

~Richard.

On Thu, Nov 26, 2015 at 6:46 PM, Dan Brickley notifications@github.com
wrote:

Ok let's get this released 'early access'...


Reply to this email directly or view it on GitHub
<#901 (comment)
.


Reply to this email directly or view it on GitHub
#901 (comment).

@chaals

This comment has been minimized.

Show comment
Hide comment
@chaals

chaals Dec 1, 2015

Contributor

+1

Contributor

chaals commented on 6080ef1 Dec 1, 2015

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment