Auto final fixes #922
Auto final fixes #922
Conversation
Update from original
1) Description for http://auto.schema.org/emissionsCO2 has been changed, because there exists no UN/CEFACT Common Code for g/km. Before: "The CO2 emissions in g/km. The property uses a number instead of a QuantitativeValue, since g/km is the dominant unit of measurement, and there is no UNCEFACT Common Code for g/km.” After: "The CO2 emissions in g/km. When used in combination with a QuantitativeValue, put "g/km" into the unitText property of that value, since there is no UN/CEFACT Common Code for "g/km"." 2) The text "This should be considered a pre-final preview release; final changes may be made after wider community review." has been removed from the extension home page. 3) "http://auto.schema.org/specialUsage" has been renamed to "http://auto.schema.org/vehicleSpecialUsage". 4) http://schema.org/CarUsageType and its predefined instances: http://schema.org/RentalVehicleUsage http://schema.org/DrivingSchoolVehicleUsage http://schema.org/TaxiVehicleUsage have been moved from schema.org core to auto.schema.org.
1) Domain: http://schema.org/Vehicle and Range: http://schema.org/Text have been added to the core’s http://schema.org/vehicleSpecialUsage. 2) Auto extension adds Range: http://schema.org/CarUsageType to http://schema.org/vehicleSpecialUsage.
Description of http://schema.org/vehicleSpecialUsage in auto extension has been removed.
|
Thanks - a few questions:
|
Ad 1. No |
|
@RichardWallis @danbri I think this extension is the first to modify the range of a property from core; can you have a look whether this is fine? If I understand correctly, the proposal is to have just Text as the range in core and Text OR http://auto.schema.org/CarUsageType. It might be simpler to move vehicleSpecialUsage to the extension completely and removing it from core. A counter argument is that in the past, we wanted all properties that are useful for typical car listing sites in the core and externalize only those relevant mostly for manufacturer pages. |
|
@W3C-GAO It would be nice to have an appspot version available for review. It should not be a big issue to set up and will be much easier for reviewers than looking at the pure code. |
|
If specialUsage is defined in the core with a range of Text, you should ~Richard On Tue, Dec 8, 2015 at 5:33 PM, Martin Hepp notifications@github.com
|
|
@RichardWallis, there is no specialUsage in the core (we had it in the auto extension before but it was changed to vehicleSpecialUsage). So now, we have vehicleSpecialUsage both in the core and in the extension. vehicleSpecialUsage in the core has just Text as the range (i.e. we propose this to be the case); in the extension we only added a range of CarUsageType in its definition. |
|
OK, sorry I was looking at the pre name change version. Principle is the same however. If vehicleSpecialUsage is defined as in the core with a range of Text, you Which as you say is what is in pull request #922 ~Richard. On Tue, Dec 8, 2015 at 8:30 PM, trypuz notifications@github.com wrote:
|
|
We created a demo site on appspot of this version of auto extension. Here it is: http://sdo-gao.appspot.com |
|
Note that this update wipes out specialUsage; normally we leave the old definition in place and indicate the newer with 'supersededBy'. In this case, since it was in the stated 'preview' release of the extension, I think we can get away with it as usage levels of specialUsage are likely very low. If it turns out to have been used significantly anywhere we can always add the old name back into the schemas for the record. |
|
Ooops - I did not remember that we agreed to remove specialUsage. Can anybody point me to the discussion? For rental cars, it is a pretty important information (and mandatory in many countries). Didn't we probably agree to move it to Product? martin hepp http://www.heppnetz.de
|
|
Yes, just a name change - sorry should have been clearer |
The following issues are addressed by that pull request: