Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use different icons for PK and FK #695

Open
aisbergde opened this issue May 18, 2020 · 2 comments
Open

use different icons for PK and FK #695

aisbergde opened this issue May 18, 2020 · 2 comments

Comments

@aisbergde
Copy link
Contributor

Expected Behavior

it should be easier to distinguish between PK and FK, also on black and white

Current Behavior

PK and FK using the same icon, the difference is only the color. it is hard to distinguish.

Possible Solution

use different icons for PK and FK which are different also on black and white output

@npetzall
Copy link
Member

Want to do it, but need help with what should be used.
Key with an FK or PK on it? Replace with FK/PK as text icon?

@aisbergde
Copy link
Contributor Author

here is a good idea:
https://i.stack.imgur.com/zAWYk.png

it is a key icon for PK and a "FK" text icon for FK. Key icons are often used and easy to understand if used for PK.

Another idea is PK1, PK2,... it would be possible to put more information about composite PK. On the other hand I think you will order the columns in the list in the order of PK and then this information is not required in the icon.

I would also think about 2 separate columns for PK and FK because a column could be PK and FK at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants