From a8821d261a2cbc43fb0bcfda2e4102a60093ab7d Mon Sep 17 00:00:00 2001 From: Dmitry Dygalo Date: Fri, 25 Sep 2020 19:58:12 +0200 Subject: [PATCH] chore: Remove ADR It wasn't really used --- .adr-dir | 1 - .github/workflows/build.yml | 1 - adr/0001-record-architecture-decisions.md | 21 ------------------ adr/0002-resolve-schema-references-lazily.md | 21 ------------------ adr/0003-delay-schema-loading.md | 21 ------------------ adr/0004-use-src-layout.md | 22 ------------------- adr/0005-use-poetry.md | 20 ----------------- ...resolve-references-load-schemas-eagerly.md | 21 ------------------ 8 files changed, 128 deletions(-) delete mode 100644 .adr-dir delete mode 100644 adr/0001-record-architecture-decisions.md delete mode 100644 adr/0002-resolve-schema-references-lazily.md delete mode 100644 adr/0003-delay-schema-loading.md delete mode 100644 adr/0004-use-src-layout.md delete mode 100644 adr/0005-use-poetry.md delete mode 100644 adr/0006-resolve-references-load-schemas-eagerly.md diff --git a/.adr-dir b/.adr-dir deleted file mode 100644 index 0a5ca20aeb..0000000000 --- a/.adr-dir +++ /dev/null @@ -1 +0,0 @@ -adr diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 37142d89c0..641ef4fa15 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -16,7 +16,6 @@ on: - 'tox.ini' - 'mypy.ini' - '!docs/**' - - '!adr/**' push: branches: - master diff --git a/adr/0001-record-architecture-decisions.md b/adr/0001-record-architecture-decisions.md deleted file mode 100644 index e784324d2a..0000000000 --- a/adr/0001-record-architecture-decisions.md +++ /dev/null @@ -1,21 +0,0 @@ -# 1. Record architecture decisions - -Date: 2019-08-08 - -## Status - -Accepted - -## Context - -We need to record the architectural decisions made on this project. - -## Decision - -We will use Architecture Decision Records, as -[described by Michael Nygard](http://thinkrelevance.com/blog/2011/11/15/documenting-architecture-decisions). - -## Consequences - -See Michael Nygard's article, linked above. For a lightweight ADR -toolset, see Nat Pryce's [adr-tools](https://github.com/npryce/adr-tools). diff --git a/adr/0002-resolve-schema-references-lazily.md b/adr/0002-resolve-schema-references-lazily.md deleted file mode 100644 index e8ea5bf423..0000000000 --- a/adr/0002-resolve-schema-references-lazily.md +++ /dev/null @@ -1,21 +0,0 @@ -# 3. Resolve schema references lazily - -Date: 2019-08-08 - -## Status - -Superseded by #6 - -## Context - -We need to have minimal performance overhead on a test collection -and avoid resolving that involves network requests. - -## Decision - -We will resolve schema references during the test execution. - -## Consequences - -Test collection phase becomes faster, also it allows to avoid -unnecessary schema resolving if certain tests are de-selected. diff --git a/adr/0003-delay-schema-loading.md b/adr/0003-delay-schema-loading.md deleted file mode 100644 index 3e81d0cd1c..0000000000 --- a/adr/0003-delay-schema-loading.md +++ /dev/null @@ -1,21 +0,0 @@ -# 4. Delay schema loading - -Date: 2019-08-08 - -## Status - -Superseded by #6 - -## Context - -We need to have minimal performance overhead on a test collection -and avoid loading that involves network requests. - -## Decision - -We will load schema during the test execution. - -## Consequences - -Test collection phase becomes faster, also it allows to avoid -unnecessary schema loading over the wire. diff --git a/adr/0004-use-src-layout.md b/adr/0004-use-src-layout.md deleted file mode 100644 index 011d786ac5..0000000000 --- a/adr/0004-use-src-layout.md +++ /dev/null @@ -1,22 +0,0 @@ -# 2. Use src layout - -Date: 2019-08-12 - -## Status - -Accepted - -## Context - -We need to have reliable distribution publishing process and always -run tests against installed package version. - -## Decision - -We will use `src` code layout as -[described by Ionel Christian Mărieș](https://blog.ionelmc.ro/2014/05/25/python-packaging/) and [Hynek Schlawack](https://hynek.me/articles/testing-packaging/). - -## Consequences - -Chances of publishing invalid/incomplete package are reduced -and the tests are executed against installed package version. diff --git a/adr/0005-use-poetry.md b/adr/0005-use-poetry.md deleted file mode 100644 index ed633cee01..0000000000 --- a/adr/0005-use-poetry.md +++ /dev/null @@ -1,20 +0,0 @@ -# 5. Use poetry - -Date: 2019-08-19 - -## Status - -Accepted - -## Context - -There is a new standardized file named `pyproject.toml` that introduce -simplified way of python packaging and dependency management. - -## Decision - -We will use [poetry](https://poetry.eustace.io/). - -## Consequences - -Using PEP 518 simplifies distribution as we have only pyproject.toml diff --git a/adr/0006-resolve-references-load-schemas-eagerly.md b/adr/0006-resolve-references-load-schemas-eagerly.md deleted file mode 100644 index 1c39ea522d..0000000000 --- a/adr/0006-resolve-references-load-schemas-eagerly.md +++ /dev/null @@ -1,21 +0,0 @@ -# 6. Resolve references & load schemas eagerly - -Date: 2019-09-15 - -## Status - -Accepted - -## Context - -Having lazily loaded schema complicates implementation and doesn't bring much value, since loading still happen during the collection phase. -References are not implemented lazily at the moment, it was missed during development. - -## Decision - -Evaluate schemas & references eagerly. - -## Consequences - -Implementation will be simpler. However, references still could be implemented lazily, -since they could be evaluated after collection phase and the tests using them could be excluded from the run.