From edd0c785f4827276e4acbea100f81a064f8a8497 Mon Sep 17 00:00:00 2001 From: Dmitry Dygalo Date: Mon, 27 Apr 2020 10:21:28 +0200 Subject: [PATCH] refactor: Use 1-based indexing in VCR cassettes To have it consistent with JUnit --- src/schemathesis/cli/cassettes.py | 2 +- test/cli/test_cassettes.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/schemathesis/cli/cassettes.py b/src/schemathesis/cli/cassettes.py index b09bfe9ee0..2b64ba99ac 100644 --- a/src/schemathesis/cli/cassettes.py +++ b/src/schemathesis/cli/cassettes.py @@ -137,7 +137,7 @@ def get_command_representation() -> str: def worker(file_handle: click.utils.LazyFile, queue: Queue) -> None: """Write YAML to a file in an incremental manner.""" - current_id = 0 + current_id = 1 stream = file_handle.open() dumper = StringDumper(stream, sort_keys=False) # type: ignore StringSerializer.__init__(dumper) # type: ignore diff --git a/test/cli/test_cassettes.py b/test/cli/test_cassettes.py index 383a65870d..023ac1fc48 100644 --- a/test/cli/test_cassettes.py +++ b/test/cli/test_cassettes.py @@ -25,8 +25,8 @@ def test_store_cassette(cli, schema_url, cassette_path): assert result.exit_code == ExitCode.OK cassette = load_cassette(cassette_path) assert len(cassette["http_interactions"]) == 3 - assert cassette["http_interactions"][0]["id"] == "0" - assert cassette["http_interactions"][1]["id"] == "1" + assert cassette["http_interactions"][0]["id"] == "1" + assert cassette["http_interactions"][1]["id"] == "2" assert cassette["http_interactions"][0]["status"] == "SUCCESS" assert cassette["http_interactions"][0]["seed"] == "1" assert float(cassette["http_interactions"][0]["elapsed"]) >= 0