Make Chicken Scheme implementation compatible with Chicken 5

[nmeum]

Hi,

I honestly don't really know much about this whole SRFI standardization process. I just found this SRFI very interesting and wanted to play around with using Chicken Scheme. Unfortunately, the provided implementation does not seem to work with Chicken 5 though this can be easily fixed using the changes proposed here. As I said, I am unfamiliar with SRFI standardization and don't know if you accept such compatibility changes after the SRFI has been finalized.

With the changes proposed here the srfi-151/chicken-test.scm test cases pass successfully with Chicken 5. Though one has to manually install srfi-151.scm as a module beforehand or add (include "srfi-151.scm") to chicken-test.scm. I am not sure how this was handled in Chicken 4. I am also unsure why chicken-test.scm is duplicated in the repository root, should that file be modified as well?

---

This PR performs the following changes:

• Fixed imports of chicken base functionality
• Replaced remove use procedure with import
• Changed imports of old numbers module to new bitwise module

[arthurgleckler]

Thank you very much for your contribution. I've merged your change and deleted the duplicate test files you pointed out. Everything is now updated on srfi.schemers.org <https://srfi.schemers.org/srfi-151>. If you'd like to learn more about the SRFI process, please read here <https://srfi.schemers.org/about.html>. You are welcome to join us!

…

On Tue, Aug 4, 2020 at 12:27 PM nmeum ***@***.***> wrote: Hi, I honestly don't really know much about this whole SRFI standardization process. I just found this SRFI very interesting and wanted to play around with using Chicken Scheme. Unfortunately, the provided implementation does not seem to work with Chicken 5 though this can be easily fixed using the changes proposed here. As I said, I am unfamiliar with SRFI standardization and don't know if you accept such compatibility changes after the SRFI has been finalized. With the changes proposed here the srfi-151/chicken-test.scm test cases pass successfully with Chicken 5. Though one has to manually install srfi-151.scm as a module beforehand or add (include "srfi-151.scm") to chicken-test.scm. I am not sure how this was handled in Chicken 4. I am also unsure why chicken-test.scm is duplicated in the repository root, should that file be modified as well? ------------------------------ This PR performs the following changes: - Fixed imports of chicken base functionality - Replaced remove use procedure with import - Changed imports of old numbers module to new bitwise module ------------------------------ You can view, comment on, or merge this pull request online at: #4 Commit Summary - Make Chicken implementation compatible with chicken 5 File Changes - *M* srfi-151/chicken-test.scm <https://github.com/scheme-requests-for-implementation/srfi-151/pull/4/files#diff-f0e93c51045f9bc99bb4b29890ab0bc8> (2) - *M* srfi-151/srfi-151.scm <https://github.com/scheme-requests-for-implementation/srfi-151/pull/4/files#diff-33b54df0fd43d602bdc08085da58e575> (5) Patch Links: - https://github.com/scheme-requests-for-implementation/srfi-151/pull/4.patch - https://github.com/scheme-requests-for-implementation/srfi-151/pull/4.diff

[nmeum]

Thanks for your work on SRFI standardization! :)

I noticed one more think though: srfi-151/chicken-test.scm and srfi-151/srfi-151.scm don't have a license header (contrary to other scheme files). Is that intended? Would it be possible to add one? I am asking because I would like to ship this code as a CHICKEN egg to ease installation for CHICKEN users.

Hope you don't mind me asking this here.

[arthurgleckler]

On Wed, Aug 5, 2020 at 12:20 AM nmeum ***@***.***> wrote: I noticed one more think though: srfi-151/chicken-test.scm and srfi-151/srfi-151.scm don't have a license header (contrary to other scheme files). Is that intended? Would it be possible to add one? I am asking because I would like to ship this code as a CHICKEN egg to ease installation for CHICKEN users.

Please feel free to send me a pull request adding the standard SRFI license from the bottom of the SRFI template <https://srfi.schemers.org/srfi-template.html>. Thanks.