Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Update plugin to work with pytest 4.1.0 #2
The latest pytest update (4.1.0) removed the get_marker function, breaking the plugin. See comment on https://docs.pytest.org/en/latest/changelog.html for details.
I wasn't sure if it was best to open an issue or this MR but since I fixed it for our project anyway, figure I'll send it your way and you can decide how to best go about it.
left a comment
Thanks. Pull-requests are always better than creating an issue...
Would you like to co-maintain this project? I am sending you github invitation.
Added the new entry to the CHANGES file and updated the version.
I've never worked with pypi but it should be an interesting experience, so sure.
I also pushed a small change to fix the tests but it only worked for Python 3.4, I'll try to take a look later into why.
Edit: okay, quick look so for 2.7 I'll try freezing the version of doit. For Python 3.3, pytest doesn't list it as supported version, so maybe we should drop it? Also maybe add 3.5, 3.6 and 3.7 to the CI script. I'll check tomorrow.
I'm not using 2.7 but pytest still supports it and the plugin works, it was just a matter of fixing the tests on the CI pipeline.
It looks good now, I'll see about the authors thing.
After that should be good to merge and I'll figure out how to publish it.
Okay, I think this is it.
If you agree with all changes we can go ahead with the merge and I'll publish it to the main site.