New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin to work with pytest 4.1.0 #2

Merged
merged 9 commits into from Jan 12, 2019

Conversation

Projects
None yet
2 participants
@marcos-alfredo
Copy link
Collaborator

marcos-alfredo commented Jan 9, 2019

Hi,

The latest pytest update (4.1.0) removed the get_marker function, breaking the plugin. See comment on https://docs.pytest.org/en/latest/changelog.html for details.
The fix is just a single line replacement.

I wasn't sure if it was best to open an issue or this MR but since I fixed it for our project anyway, figure I'll send it your way and you can decide how to best go about it.

marcos-alfredo added some commits Jan 9, 2019

replace removed function with suggested alternative
get_marker function was removed, see this for reference pytest-dev/pytest#4546
@schettino72
Copy link
Owner

schettino72 left a comment

Thanks. Pull-requests are always better than creating an issue...
Could you please also add an entry on CHANGES file?

Would you like to co-maintain this project? I am sending you github invitation.
Do you have a pypi account? I could also add you as a maintainer there so you can push a new release yourself...

Show resolved Hide resolved setup.py Outdated

marcos-alfredo added some commits Jan 10, 2019

@marcos-alfredo

This comment has been minimized.

Copy link
Collaborator

marcos-alfredo commented Jan 10, 2019

Added the new entry to the CHANGES file and updated the version.

I've never worked with pypi but it should be an interesting experience, so sure.
Just created an account there, username marcos.alfredo

I also pushed a small change to fix the tests but it only worked for Python 3.4, I'll try to take a look later into why.

Edit: okay, quick look so for 2.7 I'll try freezing the version of doit. For Python 3.3, pytest doesn't list it as supported version, so maybe we should drop it? Also maybe add 3.5, 3.6 and 3.7 to the CI script. I'll check tomorrow.

@schettino72

This comment has been minimized.

Copy link
Owner

schettino72 commented Jan 11, 2019

Are you still using python2.7? if not, just drop it...

Yes, supported versions should be 3.5 to 3.7.

@schettino72

This comment has been minimized.

Copy link
Owner

schettino72 commented Jan 11, 2019

Cool. I have just added you as a maintainer on PyPI.
Feel free to add your name somewhere on README file, or create an AUTHORS file to give credit to yourself.
Also feel free to merge changes and publish on PyPI :)

@marcos-alfredo

This comment has been minimized.

Copy link
Collaborator

marcos-alfredo commented Jan 11, 2019

I'm not using 2.7 but pytest still supports it and the plugin works, it was just a matter of fixing the tests on the CI pipeline.

It looks good now, I'll see about the authors thing.

After that should be good to merge and I'll figure out how to publish it.

@marcos-alfredo

This comment has been minimized.

Copy link
Collaborator

marcos-alfredo commented Jan 11, 2019

Okay, I think this is it.
Added my name to the readme and the setup.py file.
Changed a few others things there that I think make sense.
I've tested how to publish the plugin on the PyPI test site, you can take a look here https://test.pypi.org/project/pytest-ignore-flaky/.

If you agree with all changes we can go ahead with the merge and I'll publish it to the main site.

@schettino72 schettino72 merged commit 9030576 into schettino72:master Jan 12, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@schettino72

This comment has been minimized.

Copy link
Owner

schettino72 commented Jan 12, 2019

perfect. thanks.
if you could upload to PyPI, it would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment