Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom CSS and external links #29

Merged
merged 7 commits into from Oct 1, 2019

Conversation

@Zulko
Copy link
Collaborator

commented Oct 1, 2019

Theme changes:

  • Adds custom CSS to make Sphinx elements look better (in particular elements generated by Autodoc)
  • Adds the possibility to use html_css_files in the configuration
  • Adds the possibility to provide external links via html_theme_options

Docs changes:

  • Added the new configuration options, and corrected a couple typos.
@Zulko

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 1, 2019

@schettino72 this is all I have for now. Please have a look when you have time, and if it's fine update the pypi repo and the docs. Cheers!

@schettino72

This comment has been minimized.

Copy link
Owner

commented Oct 1, 2019

@Zulko do you have a pypi account? i will add you as admin there as well.

@Zulko

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 1, 2019

zulko on PyPI. Are you OK to move the documentation to the gh-page of this repository? This way I can update the docs more easily, and they will be located at schettino7.github.io/sphinx_press_theme.

Copy link
Owner

left a comment

Not required, but would be nice if there is a sample of autodoc

max-width: 840px;
}

/* TJE SECTION BELOW DEFINES THE APPEARANCE OF AUTODOC-GENERATED DOCS */

This comment has been minimized.

Copy link
@schettino72

schettino72 Oct 1, 2019

Owner

typo THE

This comment has been minimized.

Copy link
@Zulko

Zulko Oct 1, 2019

Author Collaborator

fixed

@@ -19,3 +19,5 @@ yarn-error.log*
*.njsproj
*.sln
*.sw*

package-lock.json

This comment has been minimized.

Copy link
@schettino72

schettino72 Oct 1, 2019

Owner

i guess good practice to include this on repo...

This comment has been minimized.

Copy link
@Zulko

Zulko Oct 1, 2019

Author Collaborator

put package-lock it back in

*
*/

@import url('https://fonts.googleapis.com/css?family=Roboto+Mono&display=swap');

This comment has been minimized.

Copy link
@schettino72

schettino72 Oct 1, 2019

Owner

not really happy about including google fonts because they are blocked in china...

This comment has been minimized.

Copy link
@Zulko

Zulko Oct 1, 2019

Author Collaborator

changed to openfonts

@schettino72

This comment has been minimized.

Copy link
Owner

commented Oct 1, 2019

Added you on pypi and also repository with site.
It is already using github pages. but i put on separate repo instead of a branch.

@Zulko Zulko merged commit 3eb2a61 into schettino72:master Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.