New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navitia: Add Nicaragua providers #181

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
8 participants
@xamanu
Copy link

xamanu commented Dec 5, 2017

This is similar to #170 in the sense that this work came out of a local initiative to map public transport data in a region where otherwise no information and no apps exist. The data was entered into OpenStreetMap and a GTFS file generated with osm2gtfs. This file is then processed by Navitia that offers the routing server for the data.

The users:
24686747041_7b63b1bdd7_z

The team:
24753934806_1e6b93179d_z

@xamanu

This comment has been minimized.

Copy link

xamanu commented Dec 5, 2017

Before considering this Pull Request, two improvements shall be done:

  • The GTFS files are currently in the process of being integrated in navitia.io, which is probably a preferred sourced over the local community's navitia server.
  • Tests needs to be provided.

@xamanu xamanu force-pushed the mapanica:nicaragua-providers branch from 8d85573 to 12f4032 Dec 5, 2017

*/
public class ManaguaProvider extends AbstractNavitiaProvider {
private static String API_REGION = "ni-managua";
private static HttpUrl API_BASE = HttpUrl.parse("http://nativia.mapanica.net/").newBuilder().addPathSegment(SERVER_VERSION).build();

This comment has been minimized.

@grote

grote Dec 5, 2017

Contributor

typo? nativia?

This comment has been minimized.

@ialokim

ialokim Dec 5, 2017

Contributor

Exactly, should be changed :)

This comment has been minimized.

@xamanu

xamanu Dec 5, 2017

Oh, yes. Fixed.

@@ -83,4 +83,7 @@

// Africa
GHANA,

// Nicaragua
ESTELI, MANAGUA,

This comment has been minimized.

@ialokim

ialokim Dec 5, 2017

Contributor

remove the comma :)

This comment has been minimized.

@xamanu

xamanu Dec 5, 2017

Which comma?

This comment has been minimized.

@ialokim

ialokim Dec 5, 2017

Contributor

The one after MANAGUA

This comment has been minimized.

@xamanu

xamanu Dec 5, 2017

It should be there, i guess. All other lines end with a comma, too.

This comment has been minimized.

@AltNico

AltNico Dec 5, 2017

Contributor

He meant the pending comma after MANAGUA, but IIRC this is allowed with enums in Java.

This comment has been minimized.

@AltNico

AltNico Dec 5, 2017

Contributor

@xamanu

It should be there, i guess. All other lines end with a comma, too.

That's because it's a list of Enum IDs, but all older revisions of this file did not have a pending comma which you just introduced. I think schildbach would like to be consistent and have no pending commas.

This comment has been minimized.

@xamanu

xamanu Dec 5, 2017

The current master also ends with a comma.

This comment has been minimized.

@schildbach

schildbach Dec 6, 2017

Owner

I'm fine with the comma at the end of the list. It helps to reduce the diff of future additions.

*/
public class ManaguaProvider extends AbstractNavitiaProvider {
private static String API_REGION = "ni-managua";
private static HttpUrl API_BASE = HttpUrl.parse("http://nativia.mapanica.net/").newBuilder().addPathSegment(SERVER_VERSION).build();

This comment has been minimized.

@ialokim

ialokim Dec 5, 2017

Contributor

Exactly, should be changed :)

@xamanu xamanu force-pushed the mapanica:nicaragua-providers branch 2 times, most recently from 532b9b8 to 7b650b6 Dec 5, 2017

@AltNico

AltNico approved these changes Dec 5, 2017

@ialokim

ialokim approved these changes Dec 6, 2017

Copy link
Contributor

ialokim left a comment

I'm fine with this now, thanks @xamanu !

@xamanu xamanu force-pushed the mapanica:nicaragua-providers branch from 7b650b6 to 2e7d4cc Dec 7, 2017

*/
public class EsteliProvider extends AbstractNavitiaProvider {
private static String API_REGION = "ni-esteli";
private static HttpUrl API_BASE = HttpUrl.parse("http://navitia.mapanica.net/").newBuilder().addPathSegment(SERVER_VERSION).build();

This comment has been minimized.

@ialokim

ialokim Dec 12, 2017

Contributor

Should be https to avoid redirecting.

*/
public class ManaguaProvider extends AbstractNavitiaProvider {
private static String API_REGION = "ni-managua";
private static HttpUrl API_BASE = HttpUrl.parse("http://navitia.mapanica.net/").newBuilder().addPathSegment(SERVER_VERSION).build();

This comment has been minimized.

@ialokim

ialokim Dec 12, 2017

Contributor

same here :)

@xamanu xamanu force-pushed the mapanica:nicaragua-providers branch from 2e7d4cc to ec4c500 Dec 12, 2017

@ialokim ialokim force-pushed the mapanica:nicaragua-providers branch from ec4c500 to 21623e6 Feb 7, 2018

@ialokim

This comment has been minimized.

Copy link
Contributor

ialokim commented Feb 7, 2018

We've switched now to navitia.io, where the two GTFS files for Managua and Esteli have been integrated into the same coverage, so that we now only have a NicaraguaProvider.

I've added some live tests, too.

@ialokim

This comment has been minimized.

Copy link
Contributor

ialokim commented Feb 28, 2018

@xamanu I think this could be renamed from WIP to merge-ready 👍

@xamanu xamanu force-pushed the mapanica:nicaragua-providers branch from 21623e6 to 1799a25 Mar 1, 2018

@xamanu xamanu force-pushed the mapanica:nicaragua-providers branch from 1799a25 to a55f616 Mar 1, 2018

@xamanu xamanu changed the title WIP: Navitia: Add Nicaragua providers Navitia: Add Nicaragua providers Mar 1, 2018

@xamanu

This comment has been minimized.

Copy link

xamanu commented Mar 1, 2018

Indeed! Now that the Nicaraguan providers have been integrated into navitia.io this is ready to be reviewed by the repository owner (@schildbach) and can hopefully be merged in.

I just rebased it on the most recent master branch, cleaned up the commit history (like removing my commit which became irrelevant) and removed the WIP from the title.

@ialokim

This comment has been minimized.

Copy link
Contributor

ialokim commented Jun 30, 2018

We've switched now to navitia.io, where the two GTFS files for Managua and Esteli have been integrated into the same coverage, so that we now only have a NicaraguaProvider.

There are news about this one: Navitia.io now also includes national transport as published by mapanica.net including ferry services from and to Ometepe!

@mayorgatellez

This comment has been minimized.

Copy link

mayorgatellez commented Jul 28, 2018

I can confirm, as someone who lives in Managua, that the data for this city is correct and works fine with Transportr.

Thank you.

@porfiriopaiz

This comment has been minimized.

Copy link

porfiriopaiz commented Jul 28, 2018

I can confirm from the ground that the data is correct and it works fine on Transportr.

@roirobo

This comment has been minimized.

Copy link

roirobo commented Jul 31, 2018

I've tested the data and can confirm that it is correct and it works like a charm.

@schildbach

This comment has been minimized.

Copy link
Owner

schildbach commented Jul 31, 2018

Merged. Thanks for sharing this, and thanks for the testing!

@schildbach schildbach closed this Jul 31, 2018

@xamanu

This comment has been minimized.

Copy link

xamanu commented Jul 31, 2018

Thanks, @schildbach for merging in. Are there any additional steps necessary to include it into the Oeffi-App? Would it be also possible to include there Managua's schematic map/plan?

@ialokim ialokim deleted the mapanica:nicaragua-providers branch Nov 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment