Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a generic text-field view to replace last-name and first-name views. #3

Closed
wants to merge 1 commit into from

Conversation

@timothyjensen
Copy link

timothyjensen commented Feb 10, 2017

Hi Alain. Forgive me if a pull request is not appropriate here. I'm wondering if you can give me your thoughts on having a generic text-field view file rather than a separate view for fields such as first-name-field.php and last-name-field.php. I'm thinking that it would make the code more reusable, but perhaps I'm overlooking something?

@timothyjensen timothyjensen changed the title Added a generic text-field view to replace last-name and first-name views. Add a generic text-field view to replace last-name and first-name views. Feb 10, 2017
@schlessera

This comment has been minimized.

Copy link
Owner

schlessera commented Feb 10, 2017

Hi Tim,

If you don't mind, please create a comment on the corresponding blog post. Feel free to link to this PR in the comment. I will then reply to that comment.

This will make it easier for people to find and join that specific discussion, as it might offer valuable insights for other people as well. I'm afraid that this PR will just get lost with time.

@schlessera

This comment has been minimized.

Copy link
Owner

schlessera commented Feb 10, 2017

Hey Tim,

I replied to your comment on the blog: https://www.alainschlesser.com/config-files-for-reusable-code-3/#comment-719

I'll close this PR now, people that read your comment will still be able to get here through your link.

Cheers,
Alain

@schlessera schlessera closed this Feb 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.