Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd a generic text-field view to replace last-name and first-name views. #3
Conversation
…iews.
timothyjensen
changed the title
This comment has been minimized.
This comment has been minimized.
|
Hi Tim, If you don't mind, please create a comment on the corresponding blog post. Feel free to link to this PR in the comment. I will then reply to that comment. This will make it easier for people to find and join that specific discussion, as it might offer valuable insights for other people as well. I'm afraid that this PR will just get lost with time. |
This comment has been minimized.
This comment has been minimized.
|
Hey Tim, I replied to your comment on the blog: https://www.alainschlesser.com/config-files-for-reusable-code-3/#comment-719 I'll close this PR now, people that read your comment will still be able to get here through your link. Cheers, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
timothyjensen commentedFeb 10, 2017
Hi Alain. Forgive me if a pull request is not appropriate here. I'm wondering if you can give me your thoughts on having a generic text-field view file rather than a separate view for fields such as first-name-field.php and last-name-field.php. I'm thinking that it would make the code more reusable, but perhaps I'm overlooking something?