Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing charset in content-type HTTP header #43

Closed
fasttime opened this issue Oct 4, 2018 · 2 comments
Closed

Missing charset in content-type HTTP header #43

fasttime opened this issue Oct 4, 2018 · 2 comments

Comments

@fasttime
Copy link

@fasttime fasttime commented Oct 4, 2018

I noticed that some JavaScript files look garbled when viewed directly in the browser via a GitCDN URL. Compare for instance

https://rawgit.com/muan/emoji/gh-pages/javascripts/emojilib/index.js (looks OK)

with

https://gitcdn.xyz/repo/muan/emoji/gh-pages/javascripts/emojilib/index.js (garbled)

Apparently GitCDN is not adding charset=utf-8 on content-type headers when serving JS files, and that causes browsers to display those files as if they were ISO-8859-1 encoded. Of course, that's not a problem when the files are loaded in a HTML page, it just looks silly to developers who look at them.

I was wondering if there is a way we can get the UTF-8 charset added. Other CDNs I'm aware of (RawGit, raw.githack.com, Staticaly, etc.) do that already.

schme16 added a commit that referenced this issue Oct 4, 2018
@schme16

This comment has been minimized.

Copy link
Owner

@schme16 schme16 commented Oct 4, 2018

Aaaaaaannnnnddddd Done: 1e00bfb

you'll probably need to clear your browsers cache before you see it go live, but otherwise it should be active now! Let me know if you have any other issues!

@fasttime

This comment has been minimized.

Copy link
Author

@fasttime fasttime commented Oct 5, 2018

Looks perfect now. Great job!

@fasttime fasttime closed this Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.