New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process External Annotations #210
Comments
We can add an extension point to the compiler pass itself, an Then, the user does not need to configure anything. |
mhmm - sounds good, but how can I reference the CompilerPass of this bundle from some other CompilerPass? |
I would call the |
I tried to implement it now - can you check it? |
@schmittjoh does to implementation look fine? |
@Ener-Getick are you the new maintainer? |
@wodka I'm a new collaborator of this bundle. I can take a look at your PRs but it's better if @schmittjoh validates them. |
Fixed in #211 |
Hi,
with the addition of #209 it is possible to create Annotations outside of this bundle.
Example of this:
now I would like to use this by just using the new annotation:
But I need to add at least the text "JMS\DiExtraBundle\Annotation" according to https://github.com/schmittjoh/JMSDiExtraBundle/blob/master/DependencyInjection/Compiler/AnnotationConfigurationPass.php#L54
Any Ideas how to extend the CompilerPass to include others as well?
I think it should first search for all classes that match MetadataProcessorInterface and then for the referenced annotations. (But this provides us with a new problem -> we would have to search for those in a typical vendor folder)
Or to add a new configuration option where we can provide Annotation Namespaces
The text was updated successfully, but these errors were encountered: