Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix secure random #55

Merged
merged 2 commits into from Apr 3, 2012

Conversation

Projects
None yet
2 participants
Contributor

marijn commented Apr 3, 2012

  • Fix container XML configuration.
  • Implement missing method JMSSecurityExtraExtension::getDoctrineConnoctionId
Contributor

marijn commented Apr 3, 2012

This is an extension of #53. I'm still having some trouble getting it to work. I'm not planning on burying you with work so if you could just point me in the right direction I can make this mergeable without to much work from your side 😄

The biggest error I'm still getting is a missing method JMSSecurityExtraExtension::getDoctrineConnectionId. My guess is it ought to look like this:

<?php

    private function getDoctrineConnectionId($guess)
    {
        return "doctrine.dbal.{$guess}_connection";
    }
Contributor

marijn commented Apr 3, 2012

Ok. This is mergeable as far as I'm concerned.

@schmittjoh schmittjoh added a commit that referenced this pull request Apr 3, 2012

@schmittjoh schmittjoh Merge pull request #55 from marijn/fix-secure-random
Fix secure random
78b5b83

@schmittjoh schmittjoh merged commit 78b5b83 into schmittjoh:master Apr 3, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment