Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP requirements inside composer.json #465

Closed
b00gizm opened this issue Jun 29, 2015 · 2 comments
Closed

Fix PHP requirements inside composer.json #465

b00gizm opened this issue Jun 29, 2015 · 2 comments

Comments

@b00gizm
Copy link

b00gizm commented Jun 29, 2015

You currently require php >=5.3.2 for your bundle, but also require jms/serializer: ^1.0.0, which itself requires PHP >= 5.4.0 and breaks for PHP 5.3.*

Don't know why, but somehow this wasn't caught by the Composer check and caused trouble on our production servers which run PHP 5.3.*

@stof
Copy link
Contributor

stof commented Jun 29, 2015

@b00gizm have you run your composer update command on a machine using a higher PHP version ? This might be the reason why it was not caught.
another possible cause would be that the dev used the --ignore-platform-reqs option (in which case he is totally responsible and changing the bundle requirements would not change anything).

Btw, to avoid issues like that in case your local PHP version does not match the prod, you should use the config > platform setting in your composer.json: https://getcomposer.org/doc/06-config.md#platform

@goetas
Copy link
Collaborator

goetas commented Jan 20, 2017

Sorry for the long feedback loop. This issue is probably already solved.
(if not feel free to re open the issue or to comment here)

Thanks

@goetas goetas closed this as completed Jan 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants