New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with recent Symfony versions #405

Merged
merged 1 commit into from Oct 11, 2016

Conversation

Projects
None yet
3 participants
@stof
Contributor

stof commented Oct 11, 2016

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #402
License Apache2

Symfony stopped storing null as the domain node, to avoid relying on the deprecated possibility of Twig to break its own API contract (which was allowing to set null in an array of nodes expected to be Twig_Node[]). So we need to check whether there is a child node domain instead of always getting it directly.

Fix compatibility with recent Symfony versions
Symfony stopped storing null as the domain node, to avoid relying on the deprecated possibility of Twig to break its own API contract.
@Nyholm

This comment has been minimized.

Show comment
Hide comment
@Nyholm

Nyholm Oct 11, 2016

Collaborator

Awesome. Thank you.

Collaborator

Nyholm commented Oct 11, 2016

Awesome. Thank you.

@Nyholm Nyholm merged commit 06da85e into schmittjoh:master Oct 11, 2016

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stof stof deleted the stof:patch-1 branch Oct 11, 2016

riccardonar added a commit to mercurio-sistemi/JMSTranslationBundle that referenced this pull request Oct 28, 2016

@jroussel

This comment has been minimized.

Show comment
Hide comment
@jroussel

jroussel Nov 30, 2016

Hello, thank you for this fix but is it possible to have a new tag for packagist (instead of having to switch to dev-master) ?

jroussel commented Nov 30, 2016

Hello, thank you for this fix but is it possible to have a new tag for packagist (instead of having to switch to dev-master) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment