Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank XML breaks XmlDeserializationVisitor error handling #701

Closed
rtek opened this issue Jan 16, 2017 · 1 comment
Closed

Blank XML breaks XmlDeserializationVisitor error handling #701

rtek opened this issue Jan 16, 2017 · 1 comment
Assignees

Comments

@rtek
Copy link

rtek commented Jan 16, 2017

This test causes an error instead of throwing XmlErrorException

    public function testError()
    {
        $this->expectException(XmlErrorException::class);
        $de = new XmlDeserializationVisitor(new CamelCaseNamingStrategy());
        $de->prepare('');
    }
Argument 1 passed to JMS\Serializer\Exception\XmlErrorException::__construct() must be an instance of LibXMLError, boolean given
@goetas goetas self-assigned this Jan 30, 2017
@goetas
Copy link
Collaborator

goetas commented Mar 9, 2017

fixed with #689

@goetas goetas closed this as completed Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants