Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Travis-CI scripts always passing #1075

Merged
merged 4 commits into from Apr 18, 2019
Merged

Fix Travis-CI scripts always passing #1075

merged 4 commits into from Apr 18, 2019

Conversation

IonBazan
Copy link
Contributor

@IonBazan IonBazan commented Apr 18, 2019

Q A
Bug fix? yes
New feature? no
Doc updated no
BC breaks? no
Deprecations? no
Tests pass? no
License MIT

Currently the tests are always marked as passed on Travis-CI due to lack of set -ex on the beginning of the tests script.
This is probably why we missed the failing tests introduced in 8ec6bea with Doctrine ORM < 2.5 when Embeddable has been introduced.

  • Skip testing Embeddable entities on Doctrine ORM <2.5
  • Bump PHPUnit minimum version to 7.5 which introduced assertIsCallable()
  • Skip loading BlogPostSeo and BlogPostWithEmbedded metadata in JMS\Serializer\Tests\Serializer\Doctrine\ObjectConstructorTest

@goetas
Copy link
Collaborator

goetas commented Apr 18, 2019

If is too difficult, why not just dropping doctrine <2.5 support?

@IonBazan
Copy link
Contributor Author

IonBazan commented Apr 18, 2019

@goetas I fixed it by moving the Article, BlogPost and Comment entities to a separate directory and loading only the specific metadata in ObjectConstructorTest .

@goetas
Copy link
Collaborator

goetas commented Apr 18, 2019

Great!

@goetas goetas merged commit c6b2342 into schmittjoh:master Apr 18, 2019
@goetas
Copy link
Collaborator

goetas commented Apr 18, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants