Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHPUnit deprecations #1123

Merged
merged 4 commits into from Sep 14, 2019

Conversation

@Majkl578
Copy link
Contributor

commented Sep 13, 2019

Q A
Bug fix? yes
Tests pass? yes
Majkl578 added 4 commits Sep 13, 2019
…Equals() and assertAttributeInstanceOf()
@Majkl578 Majkl578 force-pushed the Majkl578:phpunit-deprecations branch from 1d1d573 to 1b1b3f5 Sep 13, 2019
@Majkl578

This comment has been minimized.

Copy link
Contributor Author

commented Sep 13, 2019

Build failure unrelated.

@goetas goetas merged commit ff89778 into schmittjoh:master Sep 14, 2019
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@goetas

This comment has been minimized.

Copy link
Collaborator

commented Sep 14, 2019

Thanks @Majkl578 !

I'm always amused to see how much work has PHPUnit generated in the last 5 years! Circling around with adding features and then deprecating them...

@Majkl578 Majkl578 deleted the Majkl578:phpunit-deprecations branch Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.