Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Jun 24, 2011
  1. @fabpot

    updated VERSION

    fabpot authored
  2. @fabpot

    tweaked UPDATE file

    fabpot authored
  3. @fabpot
  4. @fabpot

    merged branch stloyd/patch-1 (PR #1425)

    fabpot authored
    Commits
    -------
    
    e993c87 Added info about Form and Validator component changes.
    
    Discussion
    ----------
    
    Adjusted UPDATE file
    
    Added info about Form and Validator component changes.
  5. @fabpot
  6. @stloyd
  7. @fabpot

    merged branch stloyd/datetimetype (PR #1419)

    fabpot authored
    Commits
    -------
    
    aeaf44a Removed unused code from DateTimeType
    3c2539f Throw exception when "date_widget" option is not equal to "time_widget"
    305c476 Overwrite child options ("widget", "empty_value") if any given
    7bc19f9 Added to `DateTimeType` extension possibility to render form as `single_text` (similar to `DateType` option) (issue #1323 it requires fix for #1205)
    17b41b2 Added to `TimeType` extension possibility to render form as `single_text` (similar to DateType option) (issue #1205) Adjusted `DateTimeType` to allow usage of this new feature
    
    Discussion
    ----------
    
    [Form][DateTimeType] Added "widget" and "empty_value" options
    
    Hey,
    
    I have just added "widget" and "empty_value" options to `DateTimeType`:
    
    * `widget` option will overwrite existing `date_widget` and `time_widget`,
    * `empty_value` behave exacly same way as it does for `ChoiceType`, `DateType` and `TimeType`
    
    Also added and `FormException` when `date_widget` is not equal to `time_widget`, now is throwed non intuitive one (this will be changed in next days to allow different values for this options).
    
    Closes #1323
  8. @fabpot

    merged branch laszlokorte/console_formatter (PR #1420)

    fabpot authored
    Commits
    -------
    
    6b72cda removed whitespace
    282a493 moved the constant from the interface back into the class
    7ec7fbe fixed inteface name
    9a82924 [Console] Extract the OutputFormatter's regular expression into the inteface.
    
    Discussion
    ----------
    
    [Console] Expose the OutputFormatter's regular expression
    
    In my ConsoleBundle(https://github.com/CoreSphere/ConsoleBundle) I needed to decorate the OutputFormatter to enable html escaping while allow to apply styles.
    
    For that I need to reuse the regular expression used in the original OutputFormatter. I think it would be cleaner exposing it than duplicating it.
    (https://github.com/CoreSphere/ConsoleBundle/blob/master/Formatter/HtmlOutputFormatterDecorator.php#L64)
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2011/06/23 12:24:43 -0700
    
    OutputFormatter is just one implementation of the interface, so the constant cannot be defined in the interface.
    
    ---------------------------------------------------------------------------
    
    by laszlokorte at 2011/06/23 13:01:46 -0700
    
    I made the false assumption all Formatters would use the same syntax for defining style. I moved it back into the class.
  9. @fabpot

    merged branch aerialls/fixed_cs (PR #1422)

    fabpot authored
    Commits
    -------
    
    272e07f [Locale] fixed CS
    
    Discussion
    ----------
    
    [Locale] fixed CS
Commits on Jun 23, 2011
  1. @aerialls

    [Locale] fixed CS

    aerialls authored
  2. @laszlokorte

    removed whitespace

    laszlokorte authored
  3. @laszlokorte
  4. @laszlokorte

    fixed inteface name

    laszlokorte authored
  5. @stloyd
  6. @laszlokorte
  7. @stloyd
  8. @stloyd
  9. @stloyd

    Added to `DateTimeType` extension possibility to render form as `sing…

    stloyd authored
    …le_text` (similar to `DateType` option) (issue #1323 it requires fix for #1205)
  10. @fabpot

    merged branch vicb/form/php-choices (PR #1415)

    fabpot authored
    Commits
    -------
    
    2cf7136 [FrameworkBundle][Form] tweak the choice widget PHP template
    
    Discussion
    ----------
    
    [FrameworkBundle][Form] tweak the choice widget PHP template
    
    * make theming easier,
    * factorize code,
    * make PHP similar to Twig (easier to maintain)
  11. @vicb
  12. @stloyd

    Added to `TimeType` extension possibility to render form as `single_t…

    stloyd authored
    …ext` (similar to DateType option) (issue #1205)
    
    Adjusted `DateTimeType` to allow usage of this new feature
  13. @fabpot

    merged branch stloyd/timetype (PR #1354)

    fabpot authored
    Commits
    -------
    
    4e3406d Sync with master and clean up
    ad5d2c1 Added to `TimeType` extension possibility to render form as `single_text` (similar to DateType option) (issue #1205) Adjusted `DateTimeType` to allow usage of this new feature
    
    Discussion
    ----------
    
    [Form][TimeType] Added possibility to render form as "single_text"
    
    Added to `TimeType` extension possibility to render form as `single_text` (similar to `DateType` option) (issue #1205)
    Adjusted `DateTimeType` to allow usage of this new feature
    
    ---------------------------------------------------------------------------
    
    by ouardisoft at 2011/06/17 03:41:18 -0700
    
    +1
    
    ---------------------------------------------------------------------------
    
    by stloyd at 2011/06/21 01:05:51 -0700
    
    @fabpot Any decision about this one ? I'm asking because I also have similar fix for #1323 but it requires this one ;-)
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2011/06/22 23:32:08 -0700
    
    @stloyd: Can you rebase to master?
    
    ---------------------------------------------------------------------------
    
    by stloyd at 2011/06/23 05:03:44 -0700
    
    @fabpot Done.
  14. @fabpot

    fixed CS

    fabpot authored
  15. @fabpot

    merged branch everzet/translation-phar-support (PR #1366)

    fabpot authored
    Commits
    -------
    
    a664a60 [Translation] support phar archives by XLIFF loader
    
    Discussion
    ----------
    
    [Translation] support phar archives by XLIFF loader
    
    Support XLIFF translation files usage from phar package.
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2011/06/19 03:06:50 -0700
    
    phar support is complex as not everything in PHP supports it. This patch only solves one area where phar is not supported. So, we need a solution that makes the entire framework phar-compatible, which is far from easy (realpath for instance cannot be used anywhere). So, I'm closing this PR and let's revisit the global phar support for 2.1.
    
    ---------------------------------------------------------------------------
    
    by everzet at 2011/06/19 04:47:49 -0700
    
    I'm not trying to package Symfony2 into phar :-) As it's indeed, very complex task even for 2.1. What i'm trying to do - i'm trying to package Behat in *.phar. And the only thing that blocks it - this PR. So, i'm not interested in full-stack phar support for entire Symfony2 framework right now, but as Symfony2 Components were created as stand-alone libs, this PR is enough to make Translation component itself supporting phar packaging. I use Translation component and XLIFF translations in Behat heavily and this PR gives me ability to create fully-working behat.phar package (tested).
    
    Also, this PR doesn't breaks anything and even more - it's exactly the same piece of code, that we have in DependencyInjection component now: https://github.com/symfony/DependencyInjection/blob/master/Loader/XmlFileLoader.php#L327.
    
    I'll be happy to work on phar support for 2.1. But for now, i can't see real reasons why Translation component can't already support it ;-)
  16. @stloyd

    Sync with master and clean up

    stloyd authored
  17. @fabpot

    fixed CS

    fabpot authored
  18. @fabpot

    merged branch Seldaek/http (PR #1414)

    fabpot authored
    Commits
    -------
    
    7db0b95 [HttpKernel] Removed unnecessary strtoupper
    0891c57 [HttpKernel] Added test
    1350645 [HttpKernel] Uppercased a few http methods
    05c9906 [HttpKernel] Suppress response content for 304 responses out of the cache
    
    Discussion
    ----------
    
    HttpCache changes for 304 responses
    
    Fixes #1413
  19. @Seldaek
  20. @Seldaek

    [HttpKernel] Added test

    Seldaek authored
  21. @Seldaek
  22. @fabpot

    [Console] fixed Process exit code

    fabpot authored
    To get the proper status for the Process, it needs to be terminated.
    Sometimes, this is not the case when we call proc_get_status, so this
    patch waits up to 1 sec to get the right information.
  23. @stloyd

    Added to `TimeType` extension possibility to render form as `single_t…

    stloyd authored
    …ext` (similar to DateType option) (issue #1205)
    
    Adjusted `DateTimeType` to allow usage of this new feature
  24. @fabpot

    merged branch lenar/non-blocking-process (PR #1403)

    fabpot authored
    Commits
    -------
    
    2d29a82 New test for Process, testing stdout and stderr at different stream sizes
    
    Discussion
    ----------
    
    Make run() fully non-blocking and fix potential other problems
    
    Multiple changes:
    
    1) make writing to process non-blocking too - otherwise there might be increased possibility for buffer deadlock
    given big enough input data. Also now it's guaranteed that all stdin data will be written.
    
    2) get rid of fgets() - fgets() isn't really good function to use in case of non-blocking sockets. Data loss possible.
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2011/06/22 07:11:55 -0700
    
    Does it make symfony#1365 obsolete?
    
    ---------------------------------------------------------------------------
    
    by lenar at 2011/06/22 14:08:14 -0700
    
    @fabpot: After reading, I really don't know. Let's hope. But ...
    
    I now improved Process tests a bit to test stdout, stderr with different stream sizes and different
    behaviours of child processes. Added it to non-blocking-process branch, commit 2d29a82.
    In my case, nothing fails, but maybe this helps other people. Or Windows people - I myself cannot test on Windows.
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2011/06/22 22:59:55 -0700
    
    These tests pass on my Linux box but fail on my Mac.
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2011/06/22 23:05:14 -0700
    
    Actually, on the Mac, the tests behave correctly but the exit code is `-1` instead of `0`.
    
    ---------------------------------------------------------------------------
    
    by lenar at 2011/06/23 01:23:51 -0700
    
    Could you check if the $this->status['running'] (after call to proc_get_status()) is true in the case you get -1.
    
    On my linux I got it -1 couple of times. 99% of time it doesn't happen. I theorized it's because sometimes the child
    process isn't finished enough and finally I got confirmation too that in case of -1 the process is still running (stats['running'] === true).
    
    But it's really almost unreproducible on my Linux. So if you have this value every time it might be easier for you to find solution.
    
    What comes into my mind:
    
    1) maybe we should poll, let's say if process is still running we usleep(1000) and the try proc_get_status() again until not running. Maybe up to a 1 sec.
    
    2) maybe, if the process is still running we can trust the return value subsequently given by proc_close()?
    
    Or maybe there's some other problem on Mac.
  25. @Seldaek
  26. @fabpot

    [Validator] restricted the True and False validator accepted values (…

    fabpot authored
    …the notion of True/False in PHP alone is too large)
Something went wrong with that request. Please try again.