Skip to content

Change the scope of ModuleCompiler->functionName to protected. #74

Closed
wants to merge 1 commit into from

2 participants

@kimlai
kimlai commented Feb 2, 2014

Hi.

This PR is related to schmittjoh/JMSTwigJsBundle#25.
To be able to output AMD compatible templates, I extended the ModuleCompiler (see https://github.com/kimlai/melikeyradio/blob/master/src/MeLikey/WebAppBundle/TwigJs/Compiler/AmdModuleCompiler.php), but to do so I need to access the functionName property in the child
class.

I couldn't come up with a way around this change for me to get require-js compatible templates.

@kimlai kimlai Change the scope of ModuleCompiler->functionName to protected.
This is related to
schmittjoh/JMSTwigJsBundle#25. To be able to
output AMD compatible templates, I extended the `ModuleCompiler` (see
https://github.com/kimlai/melikeyradio/blob/master/src/MeLikey/WebAppBundle/TwigJs/Compiler/AmdModuleCompiler.php),
but to do so I need the access the `functionName` property in the child
class.
2f2c22d
@hnrysmth
Collaborator
hnrysmth commented Feb 6, 2014

AMD compatible templates... I could see this being pretty useful. I might take a look at your AmdModuleCompiler and see if there isn't a nice way of merging that too.

@hnrysmth
Collaborator
hnrysmth commented Mar 4, 2014

Done, as of b8b5c10.

@hnrysmth hnrysmth closed this Mar 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.