chore: delete obsolete setup-branch-protection.sh#349
Merged
schmug merged 1 commit intoMay 23, 2026
Conversation
The script provisioned a branch-protection ruleset with an empty `contexts: []` check list, making it functionally hollow. Per the owner's re-scope comment on #307, dmarcheck's main-branch protection is managed entirely by the `main-protection` repository ruleset in claude-routines — this script is superseded and should not be run. No other file referenced the script. Part of #307 (code-only sub-task; Routine registration and pilot validation remain as operator actions). https://claude.ai/code/session_01DhHq3Bdfr2xKarHsbgk5Yc
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
dmarcheck | ba00153 | May 21 2026, 01:15 PM |
schmug
deleted the
chore/issue-307-delete-obsolete-branch-protection-script
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/routine-pipeline/setup-branch-protection.sh, which provisioned a branch-protection ruleset with"contexts": []— a hollow config that never enforced real CI checks.mainprotection is managed entirely by themain-protectionrepository ruleset inclaude-routines. This script is superseded and running it would apply a weaker, conflicting config.Test plan
npm test— 1043 passed, 1 pre-existing network-integration failure (same baseline asmain, unrelated to this change)npm run typecheck— 0 errors (bash-only deletion, no TypeScript impact)grep -r setup-branch-protectionreturns no results in remaining filesDeferred (operator actions, not code — see #307 comment)
Part of #307
https://claude.ai/code/session_01DhHq3Bdfr2xKarHsbgk5Yc
Generated by Claude Code