Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

passing params to next_wizard_path worked in 1.2.1, breaks in 1.3.0 #205

Closed
prognostikos opened this issue May 9, 2016 · 1 comment
Closed

passing params to next_wizard_path worked in 1.2.1, breaks in 1.3.0 #205

prognostikos opened this issue May 9, 2016 · 1 comment

Comments

@prognostikos
Copy link
Contributor

As the subject says...

This is a placeholder for me, will get back with a failing test case when on better internet.
@prognostikos
Copy link
Contributor Author

Looks like https://github.com/schneems/wicked/blob/68ba6a3f72d0575ffed3b7d1dc0a45e238f5c3ea/lib/wicked/controller/concerns/path.rb#L23 will set options to false if it's not a strong params object that's being passed in.

In my case I'm adding parameters inside the controller (not from user input/params object) and it gets nuked.

prognostikos added a commit to prognostikos/wicked that referenced this issue May 9, 2016
@prognostikos
Preserve the options hash when not a params object
1b47b0c 
Before this change, if the second argument was not a params object,
`options` would be set to false. As a Hash responds to `.to_h` just send
it before the merge no matter what.

Fixes zombocom#205
@prognostikos prognostikos mentioned this issue May 9, 2016
Merged
prognostikos added a commit to prognostikos/wicked that referenced this issue May 9, 2016
@prognostikos
Preserve the options hash when not a params object
3fc256b 
Before this change, if the second argument was not a params object,
`options` would be set to false. As a Hash responds to `.to_h` just send
it before the merge no matter what.

Fixes zombocom#205
prognostikos added a commit to prognostikos/wicked that referenced this issue May 10, 2016
@prognostikos
Preserve the options hash when not a params object
f17d7d9 
Before this change, if the second argument was not a params object,
`options` would be set to false. As a Hash responds to `#to_h` just send
it before the merge no matter what.

Fixes zombocom#205
prognostikos added a commit to prognostikos/wicked that referenced this issue May 11, 2016
@prognostikos
Preserve the options hash when not a params object
fc222ba 
Before this change, if the second argument was not a params object,
`options` would be set to false. As a Hash responds to `#to_h` just send
it before the merge no matter what.

Fixes zombocom#205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@prognostikos