Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd ability to pass a block to render_wizard #145
Conversation
This comment has been minimized.
This comment has been minimized.
What do you want to do with this? The current If the purpose is to see if the object will save, you should be doing that manually Give me a real world use case of how you want to use this feature please. |
This comment has been minimized.
This comment has been minimized.
Sorry for taking so long here. Just had time to review my intentions with this change and how could I achieve it without the changes. I'll make sure that my future PR's are analysed better before sent and with better explanation. Thanks for taking the time to look at it as well. |
This comment has been minimized.
This comment has been minimized.
Thanks for the response. Going to close this PR for now.
I appreciate the PR. I think all PRs whether they get merged or not are good times for you to dive into new code bases and for me to evaluate the current state of features and to imagine what could/should be in the future. A more thorough explanation can certainly help with discussion In general I try to state the problem (the current state of the world), explain the fix, and then explain how the world will be better after merging in the code. You can vaguely see that pattern here: rails/rails#13427 Not all my PRs get merged, but I always learn something from each of them. I consider them discussions with code. Anywhoo, i'm rambling. Thanks again for submitting the PR and thanks for using wicked |
gizotti commentedNov 24, 2014