Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input assignment #14

Merged
merged 9 commits into from Dec 7, 2020
Merged

Input assignment #14

merged 9 commits into from Dec 7, 2020

Conversation

@luciusbono
Copy link
Contributor

@luciusbono luciusbono commented Dec 6, 2020

Adds the following features:

  • Add recording from line-in L or line-in R independently as a global option alongside existing tape only mode and line-in (L+R) + tape modes
  • Input monitoring now works on left, right or left + right channels depending on input mode selected
  • renamed line-in + tape to line-in (L+R) + tape for added clarity
  • set levels of unused inputs explicitly
@schollz
Copy link
Owner

@schollz schollz commented Dec 6, 2020

@luciusbono this is absolutely amazing! thank you so much.

it seems to work perfectly, except for the line in 1+2 - its not recording when armed. i think the reason is that params:get("input type")==(1 or 4) for some reason is not hte same as params:get("input type")==1 or params:get("input type")==4. i checked this by adding these print statements when line 1+2 was enabled:

print(params:get("input type")==(1 or 4))
print(params:get("input type")==1 or params:get("input type")==4)

which prints

false
true

could you change those to the longer or-statements? also, i think instead of "line-in 1" you might just do line-in L since it is controlling the left input.

@luciusbono luciusbono marked this pull request as ready for review Dec 7, 2020
@luciusbono
Copy link
Contributor Author

@luciusbono luciusbono commented Dec 7, 2020

You're totally right, not only was that if-logic broken but I noticed that copied a few not operators that meant that the script was likely not flipping into the faster polling rates in some circumstances. Also also switched input labels, I agree that L/R makes more sense.

@schollz
Copy link
Owner

@schollz schollz commented Dec 7, 2020

look awesome! thank you :) :) :)

@schollz schollz merged commit 0008da0 into schollz:master Dec 7, 2020
@luciusbono luciusbono deleted the luciusbono:input-assignment branch Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants