Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show elapsed time when no length is given #122

Merged
merged 1 commit into from Jul 31, 2022

Conversation

gabe565
Copy link
Contributor

@gabe565 gabe565 commented Jul 9, 2022

Currently, the elapsed time is not output if a progress bar is created with length 0. This PR adds the elapsed time to the end of the progress bar in a similar way to a standard progress bar.

This PR also adds OptionSetElapsedTime which allows for hiding the elapsed time.

Example:

(5/-, 5 it/s) [1s]

Let me know if this should be considered a breaking change. I could then change elapsedTime to default to false.

Thank you!

gabe565 added a commit to clevyr/kubedb that referenced this issue Jul 9, 2022
@schollz
Copy link
Owner

schollz commented Jul 31, 2022

Ah whoops a test got changed and this needs a rebase. If you can, could you please rebase this? If not no problem, I can merge your changes through another commit

@gabe565
Copy link
Contributor Author

gabe565 commented Jul 31, 2022

Thanks for the heads up! I just pushed up a rebased commit.

@schollz
Copy link
Owner

schollz commented Jul 31, 2022

Perfect thank you!

@schollz schollz merged commit a96b4b9 into schollz:master Jul 31, 2022
1 check passed
@gabe565 gabe565 deleted the time-no-length branch Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants