Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the existing humanize function to support GB/s rates #125

Merged
merged 1 commit into from Jul 31, 2022

Conversation

NathanBaulch
Copy link
Contributor

@NathanBaulch NathanBaulch commented Jul 25, 2022

I'd like to support both B/s and GB/s file rates as well. This PR uses the existing humanizeBytes function when formatting averateRate instead of just hard coding kB and MB.

@schollz
Copy link
Owner

schollz commented Jul 31, 2022

This is so perfect, thank you!

@schollz schollz merged commit 3ebeac9 into schollz:master Jul 31, 2022
1 check passed
@NathanBaulch NathanBaulch deleted the humanize-byte-rate branch Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants